issues: 229138906

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
229138906 MDExOlB1bGxSZXF1ZXN0MTIwOTAzMjY5 1411 fixed dask prefix naming 1197350 closed 0     6 2017-05-16T19:10:30Z 2017-05-22T20:39:01Z 2017-05-22T20:38:56Z MEMBER   0 pydata/xarray/pulls/1411
  • [x] Closes #1343
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I am starting a new PR for this since the original one (#1345) was not branched of my own fork.

As the discussion there stood, @shoyer suggested that dataset.chunk should also be updated to match the latest conventions in dask naming. The relevant code is here

```python def maybe_chunk(name, var, chunks): chunks = selkeys(chunks, var.dims) if not chunks: chunks = None if var.ndim > 0: token2 = tokenize(name, token if token else var._data) name2 = '%s%s-%s' % (name_prefix, name, token2) return var.chunk(chunks, name=name2, lock=lock) else: return var

    variables = OrderedDict([(k, maybe_chunk(k, v, chunks))
                             for k, v in self.variables.items()])

```

Currently, chunk has an optional keyword argument name_prefix='xarray-'. Do we want to keep this optional?

IMO, the current naming logic in chunk is not a problem for dask and will not cause problems for the distributed bokeh dashboard (as open_dataset did).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1411/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables