issue_comments

Table actions

6 rows where issue = 229138906 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • fixed dask prefix naming · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
303213597 https://github.com/pydata/xarray/pull/1411#issuecomment-303213597 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMzIxMzU5Nw== shoyer 1217238 2017-05-22T20:39:01Z 2017-05-22T20:39:01Z MEMBER

Thanks @rabernat !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906
302147200 https://github.com/pydata/xarray/pull/1411#issuecomment-302147200 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMjE0NzIwMA== rabernat 1197350 2017-05-17T16:34:56Z 2017-05-17T16:34:56Z MEMBER

Ok, I think I fixed it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906
302130344 https://github.com/pydata/xarray/pull/1411#issuecomment-302130344 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMjEzMDM0NA== shoyer 1217238 2017-05-17T15:38:13Z 2017-05-17T15:38:13Z MEMBER

file_arg has the filename in it, no?

Actually, apparently not necessarily -- look a few lines further up to where it is defined.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906
302127457 https://github.com/pydata/xarray/pull/1411#issuecomment-302127457 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMjEyNzQ1Nw== rabernat 1197350 2017-05-17T15:29:27Z 2017-05-17T15:29:27Z MEMBER

I think this is actually a problem with providing unique names for dask. Previously, the filename ended up as part of the prefix explicitly, but now it needs to be explicitly included as input to token.

I thought that was already happening. Here is the token python token = tokenize(file_arg, group, decode_cf, mask_and_scale, decode_times, concat_characters, decode_coords, engine, chunks, drop_variables)

file_arg has the filename in it, no?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906
302124807 https://github.com/pydata/xarray/pull/1411#issuecomment-302124807 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMjEyNDgwNw== shoyer 1217238 2017-05-17T15:21:01Z 2017-05-17T15:21:01Z MEMBER

Note that the test failures are also showing different numbers from assert_allclose -- the "AssertionError: internal failure" bit is a broken error message generated by the test suite (somehow due to how we close files after we use them).

I think this is actually a problem with providing unique names for dask. Previously, the filename ended up as part of the prefix explicitly, but now it needs to be explicitly included as input to token.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906
301904032 https://github.com/pydata/xarray/pull/1411#issuecomment-301904032 https://api.github.com/repos/pydata/xarray/issues/1411 MDEyOklzc3VlQ29tbWVudDMwMTkwNDAzMg== rabernat 1197350 2017-05-16T20:22:30Z 2017-05-16T20:22:30Z MEMBER

This seems to be interacting badly with autoclose.

@pwolfram: can you give any insight into what might be going on? This is an interesting trace from travis: https://travis-ci.org/pydata/xarray/jobs/232969599#L3368

``` xarray/tests/init.py:153: in assertDatasetIdentical assert_identical(d1, d2)

a = <[AssertionError("internal failure: file must be open if autoclose=True is used.") raised in repr()] SafeRepr object at 0x7fd8d83c7e60> b = <xarray.Dataset> ... ```

Does autoclose assume that the dask object names actually match the filenames?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixed dask prefix naming 229138906

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);