issues: 185181822
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
185181822 | MDExOlB1bGxSZXF1ZXN0OTA4NTM1ODU= | 1060 | Remove obsolete NetCDF4 Error catch | 10050469 | closed | 0 | 7 | 2016-10-25T17:25:33Z | 2017-05-22T08:58:21Z | 2017-05-22T08:58:21Z | MEMBER | 0 | pydata/xarray/pulls/1060 | [edit: this original PR was replaced with another change: "remove obsolete NetCDF4 Error catch"] This allows to give a customized NetCDF4 object to the DataStore. I needed this for Salem's diagnostic variables: https://github.com/fmaussion/salem/blob/master/salem/sio.py#L737-L751 My workaround (a very shallow subclass of NetCDF4DataStore) is fine for me, so I won't be offended if you decide not to merge. On a related issue, the IndexError catch which happens here is also giving me trouble, since it hides bugs in my code. I know I'm kind of misusing the backend, but I find it very useful the way it is. I'm open to any suggestion to make it more elegant. Thanks! |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/1060/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |