issue_comments

Table actions

7 rows where issue = 185181822 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Remove obsolete NetCDF4 Error catch · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
303040925 https://github.com/pydata/xarray/pull/1060#issuecomment-303040925 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDMwMzA0MDkyNQ== fmaussion 10050469 2017-05-22T08:58:21Z 2017-05-22T08:58:21Z MEMBER

Closing this, might reopen later if needed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
267681380 https://github.com/pydata/xarray/pull/1060#issuecomment-267681380 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI2NzY4MTM4MA== fmaussion 10050469 2016-12-16T19:52:17Z 2016-12-16T19:52:17Z MEMBER

I don't have a strong opinion on this. I guess that older systems are bound to a specific version of the C netCDF library, not with a specific python netCDF4 lib, right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
267676265 https://github.com/pydata/xarray/pull/1060#issuecomment-267676265 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI2NzY3NjI2NQ== shoyer 1217238 2016-12-16T19:29:19Z 2016-12-16T19:29:19Z MEMBER

I think the main question is: what is the oldest version of netCDF4 we want to support? Once we decide that, the action here should be pretty clear.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
267675976 https://github.com/pydata/xarray/pull/1060#issuecomment-267675976 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI2NzY3NTk3Ng== fmaussion 10050469 2016-12-16T19:27:58Z 2016-12-16T19:27:58Z MEMBER

@shoyer we should reach a decision about this small PR: I don't mind closing it as it's not a big deal...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
257820198 https://github.com/pydata/xarray/pull/1060#issuecomment-257820198 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI1NzgyMDE5OA== fmaussion 10050469 2016-11-02T09:57:24Z 2016-11-02T09:57:24Z MEMBER

Reverted __init__ back the way it was, but removed the error catch.

@shoyer feel free to close if you are reluctant to merge this, I don't mind.

I still think that it would be great to have a simple way to give custom "netcdf4 like" objects to xarray, though. If you have any suggestion on a good way to go I'd be happy to try an implementation

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
256126088 https://github.com/pydata/xarray/pull/1060#issuecomment-256126088 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI1NjEyNjA4OA== fmaussion 10050469 2016-10-25T18:25:49Z 2016-10-25T18:25:49Z MEMBER

Sure, no pressure!

So what about leaving __init__ the way it is and remove that IndexError catch?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822
256109866 https://github.com/pydata/xarray/pull/1060#issuecomment-256109866 https://api.github.com/repos/pydata/xarray/issues/1060 MDEyOklzc3VlQ29tbWVudDI1NjEwOTg2Ng== shoyer 1217238 2016-10-25T17:53:03Z 2016-10-25T17:53:03Z MEMBER

I'm a little nervous about this. The entire datastore API needs some serious rethinking for extensibility.

We may be able to delete that IndexError catch -- that exists to work around a netCDF4 bug that lasted between versions 1.1.2 (Dec 16, 2014) and 1.2.1 (Oct 15, 2015).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove obsolete NetCDF4 Error catch 185181822

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);