issues: 1535387692

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1535387692 PR_kwDOAMm_X85HfYz8 7444 Preserve `base` and `loffset` arguments in `resample` 6628425 closed 0     7 2023-01-16T19:16:39Z 2023-03-08T18:16:12Z 2023-03-08T16:55:22Z MEMBER   0 pydata/xarray/pulls/7444

While pandas is getting set to remove the base and loffset arguments in resample, we have not had a chance to emit a deprecation warning for them yet in xarray (https://github.com/pydata/xarray/issues/7420). This PR preserves their functionality in xarray and should hopefully give users some extra time to adapt. Deprecation warnings for each are added so that we can eventually remove them.

I've taken the liberty to define a TimeResampleGrouper object, since we need some way to carry the loffset argument through the resample chain, even though it will no longer be allowed on the pd.Grouper object. Currently it is not particularly complicated, so hopefully it would be straightforward to adapt to what is envisioned in https://github.com/pydata/xarray/issues/6610#issuecomment-1341296800.

  • [x] closes #7266
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7444/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables