issue_comments

Table actions

4 rows where issue = 1198058137 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Fix `xr.where(..., keep_attrs=True)` bug · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1095828767 https://github.com/pydata/xarray/pull/6461#issuecomment-1095828767 https://api.github.com/repos/pydata/xarray/issues/6461 IC_kwDOAMm_X85BUQUf dcherian 2448579 2022-04-12T02:07:43Z 2022-04-12T02:07:43Z MEMBER

LGTM. Thanks @slevang 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `xr.where(..., keep_attrs=True)` bug 1198058137
1094166371 https://github.com/pydata/xarray/pull/6461#issuecomment-1094166371 https://api.github.com/repos/pydata/xarray/issues/6461 IC_kwDOAMm_X85BN6dj slevang 39069044 2022-04-10T03:16:24Z 2022-04-10T03:16:24Z CONTRIBUTOR

Good point @keewis. This version should maintain the expected behavior in that case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `xr.where(..., keep_attrs=True)` bug 1198058137
1093985184 https://github.com/pydata/xarray/pull/6461#issuecomment-1093985184 https://api.github.com/repos/pydata/xarray/issues/6461 IC_kwDOAMm_X85BNOOg keewis 14808389 2022-04-09T12:37:15Z 2022-04-09T12:38:16Z MEMBER

if cond has attrs but x is not a xarray object this will take the attrs of cond (apply_ufunc with keep_attrs=True). I don't think that implicit behavior is desirable (we can use keep_attrs="override" to get the attrs of cond) so maybe it is better to instead change the lambda to do a "getitem with a default of {}"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `xr.where(..., keep_attrs=True)` bug 1198058137
1093637133 https://github.com/pydata/xarray/pull/6461#issuecomment-1093637133 https://api.github.com/repos/pydata/xarray/issues/6461 IC_kwDOAMm_X85BL5QN max-sixty 5635139 2022-04-09T03:25:28Z 2022-04-09T03:25:28Z MEMBER

Thanks @slevang ! Would it be possible to add a test?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `xr.where(..., keep_attrs=True)` bug 1198058137

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);