issues: 1029142676
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1029142676 | PR_kwDOAMm_X84tVCEd | 5875 | fix test with pseudonetcdf 3.2 | 10194086 | closed | 0 | 5 | 2021-10-18T13:49:23Z | 2021-10-22T21:24:09Z | 2021-10-22T21:23:34Z | MEMBER | 0 | pydata/xarray/pulls/5875 | Fixes one part of #5872 pseudoNETCDF adds two attrs to ict files, which breaks the following two tests: Test 1: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/tests/test_backends.py#L3944 Test 2: I reproduced the test file so that the tests pass again. To reproduce the file I used the following bit of code: ```python import xarray as xr from xarray.tests import test_backends fN = "xarray/tests/data/example.ict" fmtkw = {"format": "ffi1001"} ds = xr.open_dataset(fN, engine="pseudonetcdf", backend_kwargs={"format": "ffi1001"}) c = test_backends.TestPseudoNetCDFFormat() c.save(ds, fN, **fmtkw) ``` The @barronh I would appreciate your review here - I am not sure if this is the right approach. |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/5875/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |