issue_comments

Table actions

3 rows where user = 895458 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • mwtoews · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1302724471 https://github.com/pydata/xarray/pull/7253#issuecomment-1302724471 https://api.github.com/repos/pydata/xarray/issues/7253 IC_kwDOAMm_X85Npf93 mwtoews 895458 2022-11-03T22:01:49Z 2022-11-03T22:01:49Z CONTRIBUTOR

I've looked into this further, and what I see is that $Format:%(describe:tags=true)$ requires git 2.35.0 (January 2022) or later; see docs here. Earlier versions will just leave "%(describe:tags=true)" without substitution or error. I presume "git archive" would be running on newish GitHub actions versions of git.

As for the updated format with a numeric match, I don't think it makes any difference. Testing with git 2.38.1: $ git log -2 --format="%(describe:tags=true,match=*[0-9]*)" v2022.10.0-47-g2e6fab2f v2022.10.0-46-g6179d8e8 $ git log -2 --format="%(describe:tags=true)" v2022.10.0-47-g2e6fab2f v2022.10.0-46-g6179d8e8 but I've amended this PR with the new change to keep it aligned with the latest docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove setuptools-scm-git-archive, require setuptools-scm>=7 1434498245
1242590184 https://github.com/pydata/xarray/pull/6979#issuecomment-1242590184 https://api.github.com/repos/pydata/xarray/issues/6979 IC_kwDOAMm_X85KEGvo mwtoews 895458 2022-09-10T01:37:43Z 2022-09-10T01:37:43Z CONTRIBUTOR

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

My guess is that it hasn't been needed since #4519 when MANIFEST.in was cleaned up by @max-sixty. It hasn't been needed since #3714. Also, from the check-manifest docs here:

Note that setuptools_scm usually makes MANIFEST.in files obsolete. Having one is helpful only if you intend to build an sdist and then use that sdist to perform further builds, instead of building from a source checkout.

Is this relevant? From my laptop, check-manifest takes ~10 seconds to compute. What value does it bring to CI checking?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove unnecessary build dependencies, use build defaults, strict twine check 1359451944
950734046 https://github.com/pydata/xarray/pull/5879#issuecomment-950734046 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X844qwze mwtoews 895458 2021-10-25T09:46:37Z 2021-10-25T09:46:37Z CONTRIBUTOR

@max-sixty whats-new entry added, check to see if the paragraph is ok. I'll hold off clarifying file-like vs path-like in the docs for now, but will consider a doc intersphinx link at some time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);