issue_comments: 1242590184

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6979#issuecomment-1242590184 https://api.github.com/repos/pydata/xarray/issues/6979 1242590184 IC_kwDOAMm_X85KEGvo 895458 2022-09-10T01:37:43Z 2022-09-10T01:37:43Z CONTRIBUTOR

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

My guess is that it hasn't been needed since #4519 when MANIFEST.in was cleaned up by @max-sixty. It hasn't been needed since #3714. Also, from the check-manifest docs here:

Note that setuptools_scm usually makes MANIFEST.in files obsolete. Having one is helpful only if you intend to build an sdist and then use that sdist to perform further builds, instead of building from a source checkout.

Is this relevant? From my laptop, check-manifest takes ~10 seconds to compute. What value does it bring to CI checking?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1359451944