home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

4 rows where user = 4502 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 4

  • Shoudn't `assert_allclose` transpose datasets? 1
  • A broadcasting sum for xarray.Dataset 1
  • FacetGrid padding goes very bad when cartopy projection specified 1
  • Datatype for a 'shape specification' of a Dataset / DataArray 1

user 1

  • mjwillson · 4 ✖

author_association 1

  • NONE 4
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1183534601 https://github.com/pydata/xarray/issues/6680#issuecomment-1183534601 https://api.github.com/repos/pydata/xarray/issues/6680 IC_kwDOAMm_X85Gi04J mjwillson 4502 2022-07-13T18:17:05Z 2022-07-13T18:17:05Z NONE

Thanks, that looks interesting, although sounds like it's addressing a slightly different problem; I'm not so much interested in validation of external inputs, more just in having some basic datatypes that can be used to specify dims/shape/coords as templates for DataArray / Datasets internally within my codebase.

Some things I'm looking for but don't appear to be supported: * Support for specifying coords * __hash__, __eq__ etc for the Schema objects * Convenient APIs to alter and combine these Schemas in similar ways to what can be done with DataArray / Datasets themselves, e.g. adding/removing dimensions, broadcasting against eachother etc -- perhaps mirroring APIs like expand_dims that can be used on DataArray / Dataset themself, to the extent this makes sense.

Feels to me that it would make sense to have these basic datatypes inside xarray, perhaps with something like xarray-schema providing extra validation helpers etc on top of them? But just my 2 cents :)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Datatype for a 'shape specification' of a Dataset / DataArray 1266308714
1178897408 https://github.com/pydata/xarray/issues/6053#issuecomment-1178897408 https://api.github.com/repos/pydata/xarray/issues/6053 IC_kwDOAMm_X85GRIwA mjwillson 4502 2022-07-08T11:49:23Z 2022-07-08T11:49:23Z NONE

Re xr.broadcast(ds)[0].sum(dims) -- Thanks, that's neat and may be useful as a workaround, but it looks like it could incur significant extra CPU and RAM costs (tiling all variables to the full size in memory before summing over the tiled values)? Or is there some clever optimisation under the hood which would avoid this?

I also only wanted it to (behave as though it) broadcast the dims that are summed over, but this looks like it will broadcast all dims including those not summed over?

Overall I think it'd be better to have an option on sum (like missing_dim='broadcast' as suggested in #6749), rather than documenting a partial workaround like this, given the caveats attached to the workaround and that (to me at least) the broadcasting sum is more in keeping with the usual mathematical semantics of 'sum' than what 'sum' currently does.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  A broadcasting sum for xarray.Dataset 1074303184
1128770505 https://github.com/pydata/xarray/issues/5733#issuecomment-1128770505 https://api.github.com/repos/pydata/xarray/issues/5733 IC_kwDOAMm_X85DR6vJ mjwillson 4502 2022-05-17T11:48:26Z 2022-05-17T11:48:26Z NONE

+1 for a check_dim_order option to .equals, assert_equal that can be disabled. (Ideally I think the default would be not to check dim order, but that ship has sailed now).

Or failing that, it would at least be nice to have xarray.testing.assert_equal_modulo_dim_order etc. When writing tests I usually don't care about dimension order and it's frustrating to have to manually do e.g. xarray.testing.assert_allclose(a, b.transpose(a.dims)).

As pointed out, most of the xarray API is dimension-order-invariant and so it's odd to have no supported way to do comparisons in a dimension-order-invariant way.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Shoudn't `assert_allclose` transpose datasets? 977544678
1084793162 https://github.com/pydata/xarray/issues/6429#issuecomment-1084793162 https://api.github.com/repos/pydata/xarray/issues/6429 IC_kwDOAMm_X85AqKFK mjwillson 4502 2022-03-31T16:07:53Z 2022-03-31T16:07:53Z NONE

For now I am working around this using:

python orig_tight_layout = mpl.figure.Figure.tight_layout mpl.figure.Figure.tight_layout = lambda *a: None try: xarray.plot.pcolormesh(...args...) finally: mpl.figure.Figure.tight_layout = orig_tight_layout

obviously you don't get a tight layout this way, but the proportions are a lot better.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  FacetGrid padding goes very bad when cartopy projection specified 1188262115

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 13.913ms · About: xarray-datasette