issue_comments

In terms of maintenance burden, I would say that the future of the THREDDS server is uncertain. I am no longer at TAMU, so no longer in charge of keeping it up. And there are other issues that may make it difficult to keep up, even in the near term.

So, I think relying on the accessability of this particular dataset even in the near term is not a good idea, unfortunately.

So, that bit of code that references the THREDDS server was just to explain how the (heavily subsetted) data was processed and put into the xarray example datasets. It's not necessary for the example to run, though it could be interesting. I have three solutions, roughly in order of my preference:

1. Keep the subsetting code for reference, but just quote it, so it does not run. Delete the reference to the data server as the subsetting can be considered generic and just for reference.
2. Delete the whole section on subsetting.
3. Update the data server to http://pong.tamu.edu/thredds/dodsC/NcML/txla_hindcast_agg_chunk. I put this last, as I am concerned the data server will move or be disrupted again, and so this woudl be something that would need to be perpetually fixed. Not ideal.

The problem was only with very large arrays, so difficult to reproduce here.

Fortunately, when I just now updated to the very latest xarray/dask, the problem seems to have gone away.

I was puzzled because things worked fine -- as expected -- but only for smaller arrays. I will close this issue.

Looks like it was an easy fix. Thanks! I'll check it out soon.

I was wondering why the checksum kept failing. I'm glad that it's fixed now.

On Fri, Aug 23, 2019 at 9:11 AM Deepak Cherian notifications@github.com wrote:

It looks awesome!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFSAUGSDJVR3SMCFONTQGAD2BA5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AU3WI-23issuecomment-2D524373465&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=jNHhw3-wczG-R1InYBWYHh1uySwOv2LvBhXHalRpLiM&s=4IE-mPoo-xIwygm2i5CE6JBKiZjK9AH9Acgx5swXjiM&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFQJTIUV6SXZI5H4EMLQGAD2BANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=jNHhw3-wczG-R1InYBWYHh1uySwOv2LvBhXHalRpLiM&s=x5ZRvEPW7XBD1pfrzhF1Cszg_rgQ-qAyEysBTPrfTDY&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

Hopefully these changes are all done now. I added my credit to 'Enhancements' instead of 'New functions/methods'; hope I guessed right. I didn't see any other examples of notebooks added.

On Fri, Aug 2, 2019 at 5:24 AM Ryan Abernathey notifications@github.com wrote:

I am returning to this after some vacation. Thanks so much @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= for this great example!

The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge.

• Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry)
• Remove or resolve the commented-out code in the example.
• Add credit to @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= in whats-new.rst

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFROYNHJ7S2DREKVOC3QCQDPRA5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NLNPA-23issuecomment-2D517650108&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=t-z2yW4pb_z0ymnYO-k9w-VH5rMcQ050xTkIM9AKC5U&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFU4QP7IADADC2NTS3DQCQDPRANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=8rqgwomPBkre8gH1dTw4pH2u67J2wpVX7h_2Eh80mCE&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

I posted an issue to hvplot.xarray ( https://github.com/pyviz/hvplot/issues/244) where hvplot does not do the right thing. But matplotlib (and hence also xarray.plot) do the right thing.

On Wed, Jul 17, 2019 at 6:40 PM Deepak Cherian notifications@github.com wrote:

Thanks @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=lYvy351ebI1zHRWmzq6wpEjUIodwAqOPjEHPdhrnt74&s=7y9VzsWhKiPnJtrkl28cE3aKOFnZn3A8y1m8aDlBbck&e=, good to see you here.

I think this is probably easy to fix by using xr.broadcast to broadcast things before extracting the numpy arrays. Can you send in a PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_issues_3138-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFVIUFYCH6SJD6QFBO3P76UVRA5CNFSM4IESVD3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2G4PNQ-23issuecomment-2D512608182&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=lYvy351ebI1zHRWmzq6wpEjUIodwAqOPjEHPdhrnt74&s=ZMfEYrmiIqELTnEsLhdTmX84GQzpHrW3AcGCYix6pok&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFUEC7RTCML5UOPCBBLP76UVRANCNFSM4IESVD3A&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=lYvy351ebI1zHRWmzq6wpEjUIodwAqOPjEHPdhrnt74&s=qz9PhAwicJx-Z8yEFMVwM06TdQiAe0toEP2C6cUF2Yw&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

OK, I closed the other pull request, and updated this branch.

I'm having a hard time getting the docs to compile, they fail when loading the ROMS_example.nc file, though I switched to xr.tutorial.open_dataset('ROMS_example.nc'). Is there something else I need to do? I pushed a revised version.

I'll try to get this done very soon.

On Sun, Jul 14, 2019 at 8:33 PM Ryan Abernathey notifications@github.com wrote:

@hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=hdRQyVYJ5Li194ZIzAWhJ0SsneZ15DdjqOya-Uegoo8&e= - thanks so much for this! Now that pydata/xarray-data#13 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray-2Ddata_pull_13&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=8HH7PmBIx0_3Xe10MPEPiXoT0X_6Pj--82mnkmSXS8w&e= has been merged, can you try to update your example to use the xr.tutorial.open_dataset('ROMS_example.nc') function?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFXWQ23YSBUMI4YKYUDP7PHW7A5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4RU2Y-23issuecomment-2D511253099&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=ArFBmSuyA9yQqzaU4k0HRy5Ty4Fsn3lR8By69c4kjjs&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFUQZR7KG4FCGEAB2PDP7PHW7ANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=SzNZLx3vqSjXyP508p1VXkBQ9WFnNIWR7JEjMTMHA0w&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

To follow up with this, plotting using 'x' and 'y' kwargs works fine for now, even when the variable coordinates do not share the same number of dimensions. (i.e., a common case of plotting a cross section with sigma- or s-coordinates where the horizontal variable is 1D, but the vertical variable is 2D). So, I think this great, and should cover most use cases.

The only approach I can think of to do this automatically would be to find variable coordinates that have matching dimensions. This would probably work in lots of cases, but unexpectedly break in others. I think I would prefer explicit over clever, unless we can think of a way to do it that won't break.