issue_comments

Table actions

3 rows where user = 19871268 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • lukeconibear · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1230826185 https://github.com/pydata/xarray/pull/6961#issuecomment-1230826185 https://api.github.com/repos/pydata/xarray/issues/6961 IC_kwDOAMm_X85JXOrJ lukeconibear 19871268 2022-08-29T20:27:49Z 2022-08-29T20:27:49Z CONTRIBUTOR

Thanks! This should merge on green. Also, I see that this is your first PR here - welcome to xarray!

Great, thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of random numbers in `test_weighted.test_weighted_operations_nonequal_coords` 1353447485
1230649378 https://github.com/pydata/xarray/pull/6961#issuecomment-1230649378 https://api.github.com/repos/pydata/xarray/issues/6961 IC_kwDOAMm_X85JWjgi lukeconibear 19871268 2022-08-29T17:49:50Z 2022-08-29T17:49:50Z CONTRIBUTOR

Thanks for the PR - Did you run into a problem with the random data or are you trying to clean up the tests?

I think I'm ok with the change but could you rename the params of the function? (This will need some more changes than indicated below). Also we don't write docstrings for tests as they are not meant for public consumption (but fine to leave it).

You're welcome :)

Stephan found this test failed because of the global random seed, and suggested to remove the dependency on it.

Sure, I've added those changes in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of random numbers in `test_weighted.test_weighted_operations_nonequal_coords` 1353447485
1229560785 https://github.com/pydata/xarray/issues/6962#issuecomment-1229560785 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85JSZvR lukeconibear 19871268 2022-08-28T21:46:55Z 2022-08-28T21:46:55Z CONTRIBUTOR

Which mypy version are you using?

0.971

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);