issue_comments: 1230649378

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6961#issuecomment-1230649378 https://api.github.com/repos/pydata/xarray/issues/6961 1230649378 IC_kwDOAMm_X85JWjgi 19871268 2022-08-29T17:49:50Z 2022-08-29T17:49:50Z CONTRIBUTOR

Thanks for the PR - Did you run into a problem with the random data or are you trying to clean up the tests?

I think I'm ok with the change but could you rename the params of the function? (This will need some more changes than indicated below). Also we don't write docstrings for tests as they are not meant for public consumption (but fine to leave it).

You're welcome :)

Stephan found this test failed because of the global random seed, and suggested to remove the dependency on it.

Sure, I've added those changes in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1353447485