issue_comments

Table actions

3 rows where issue = 988158051 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Implement __sizeof__ on objects? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
933822350 https://github.com/pydata/xarray/issues/5764#issuecomment-933822350 https://api.github.com/repos/pydata/xarray/issues/5764 IC_kwDOAMm_X843qP-O shoyer 1217238 2021-10-04T20:16:48Z 2021-10-04T20:16:48Z MEMBER

I don't love going against the guidance from Python core developers. My gut is that a Dask-specific protocol may be safer. That said, if Dask is the only library using sys.getsizeof() for some real purpose, then perhaps this is safe enough.

There's still some ambiguity to me about exactly what should be included in "size of" (e.g., do we include lazy values or not?) but we can probably figure that out. I suspect Xarray's implementation would be need to be recursive in some way, to handle nested Dask or lazy arrays.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement __sizeof__ on objects? 988158051
932811398 https://github.com/pydata/xarray/issues/5764#issuecomment-932811398 https://api.github.com/repos/pydata/xarray/issues/5764 IC_kwDOAMm_X843mZKG TomAugspurger 1312546 2021-10-02T19:48:05Z 2021-10-02T19:48:05Z MEMBER

Mmm for better or worse, Dask relies on sizeof to estimate the memory usage of objects at runtime. We could move that over to some new duck-typed interface like using .nbytes if it's around, but not all objects will want to expose an nbytes attribute in their API.

IMO, I think the best path is for objects to implement __getsizeof__ unless there's some downside I'm missing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement __sizeof__ on objects? 988158051
914051097 https://github.com/pydata/xarray/issues/5764#issuecomment-914051097 https://api.github.com/repos/pydata/xarray/issues/5764 IC_kwDOAMm_X842e1AZ shoyer 1217238 2021-09-07T07:12:07Z 2021-09-07T07:12:07Z MEMBER

It seems like the concensus from https://bugs.python.org/issue15436 is that only C extension types should implement __sizeof__.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement __sizeof__ on objects? 988158051

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);