issue_comments: 933822350

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5764#issuecomment-933822350 https://api.github.com/repos/pydata/xarray/issues/5764 933822350 IC_kwDOAMm_X843qP-O 1217238 2021-10-04T20:16:48Z 2021-10-04T20:16:48Z MEMBER

I don't love going against the guidance from Python core developers. My gut is that a Dask-specific protocol may be safer. That said, if Dask is the only library using sys.getsizeof() for some real purpose, then perhaps this is safe enough.

There's still some ambiguity to me about exactly what should be included in "size of" (e.g., do we include lazy values or not?) but we can probably figure that out. I suspect Xarray's implementation would be need to be recursive in some way, to handle nested Dask or lazy arrays.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   988158051