issue_comments

Table actions

6 rows where issue = 987559143 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • remove _ensure_plottable · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
912390733 https://github.com/pydata/xarray/pull/5763#issuecomment-912390733 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842YfpN github-actions[bot] 41898282 2021-09-03T09:17:10Z 2021-10-24T10:56:33Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   53m 30s :stopwatch: 16 209 tests 14 462 :heavy_check_mark: 1 736 :zzz: 11 :x: 90 450 runs  82 204 :heavy_check_mark: 8 180 :zzz: 66 :x:

For more details on these failures, see this check.

Results for commit 8ecbb390.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143
912376483 https://github.com/pydata/xarray/pull/5763#issuecomment-912376483 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842YcKj pep8speaks 24736507 2021-09-03T08:55:22Z 2021-10-24T10:33:03Z NONE

Hello @dschwoerer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 4:1: F401 'datetime.datetime' imported but unused

Comment last updated at 2021-10-24 10:33:03 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143
912724289 https://github.com/pydata/xarray/pull/5763#issuecomment-912724289 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842ZxFB Illviljan 14371165 2021-09-03T18:19:02Z 2021-09-03T18:19:02Z MEMBER

What would you expect the plot to look like if you input a complex number or a multiindex along the x-axis? I think I would expect it to be shown like a flattened array. And you can kind of get away with that if you cast the arrays to string before hand.

```python x = 1j * np.arange(0, 5) y = np.arange(5, 10) plt.plot(x, y) ComplexWarning: Casting complex values to real discards the imaginary part return np.asarray(x, float) ``` ![image](https://user-images.githubusercontent.com/14371165/132037646-8ade69af-9201-4218-a2d2-1cb1c6954328.png) ```python x = 1j * np.arange(0, 5) y = np.arange(5, 10) plt.plot(np.vectorize(str)(x), y) ``` ![image](https://user-images.githubusercontent.com/14371165/132037845-cf04623e-5f36-4d65-b5b4-b2433366fe14.png) ```python x = 1j + np.arange(0, 5) y = np.arange(5, 10) plt.plot(np.vectorize(str)(x), y) ``` ![image](https://user-images.githubusercontent.com/14371165/132039166-720de3f9-ef16-419b-aaf6-68f9dac6c59f.png) ```python import pandas as pd arrays = [[1, 1, 2, 2], ['red', 'blue', 'red', 'blue']] a = pd.MultiIndex.from_arrays(arrays, names=('number', 'color')).to_numpy() b = np.arange(4, 8) plt.plot(np.vectorize(str)(a), b) ``` ![image](https://user-images.githubusercontent.com/14371165/132048322-fb83cdbf-9720-4ed4-b75e-52bb7a41055f.png) 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143
912707634 https://github.com/pydata/xarray/pull/5763#issuecomment-912707634 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842ZtAy dcherian 2448579 2021-09-03T17:50:20Z 2021-09-03T17:50:20Z MEMBER

The error for multiindex plotting is not very informative "setting array element with sequence" so I would still keep _ensure_plottable to raise a nice error for that.

for the tests that now work, we should check that the output is reasonable, so I wouldn't delete them

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143
912630631 https://github.com/pydata/xarray/pull/5763#issuecomment-912630631 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842ZaNn dschwoerer 5637662 2021-09-03T15:40:59Z 2021-09-03T15:40:59Z CONTRIBUTOR

I think there are several options:

  1. remove the offending tests (simple)
  2. reintroduce _ensure_plottable but only check for multiindex. This has still the issue that it might at some point be possible, and the tests need to be changed and _ensure_plottable needs to be changed
  3. Change the test to check for any error. This basically just means we are checking it isn't working, which I see only limited value in.

Which of these options would you prefer?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143
912620738 https://github.com/pydata/xarray/pull/5763#issuecomment-912620738 https://api.github.com/repos/pydata/xarray/issues/5763 IC_kwDOAMm_X842ZXzC dcherian 2448579 2021-09-03T15:26:02Z 2021-09-03T15:26:02Z MEMBER

Thanks @dschwoerer This makes sense to me.

A lot of failed tests are checking for the raised error. We will need to update these to make sure the plotting worked.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove _ensure_plottable 987559143

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);