home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 912630631

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5763#issuecomment-912630631 https://api.github.com/repos/pydata/xarray/issues/5763 912630631 IC_kwDOAMm_X842ZaNn 5637662 2021-09-03T15:40:59Z 2021-09-03T15:40:59Z CONTRIBUTOR

I think there are several options:

  1. remove the offending tests (simple)
  2. reintroduce _ensure_plottable but only check for multiindex. This has still the issue that it might at some point be possible, and the tests need to be changed and _ensure_plottable needs to be changed
  3. Change the test to check for any error. This basically just means we are checking it isn't working, which I see only limited value in.

Which of these options would you prefer?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  987559143
Powered by Datasette · Queries took 0.512ms · About: xarray-datasette