issue_comments

Table actions

2 rows where issue = 959317311 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Combine='by_coords' and concat dim deprecation in open_mfdataset · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
892013117 https://github.com/pydata/xarray/pull/5669#issuecomment-892013117 https://api.github.com/repos/pydata/xarray/issues/5669 IC_kwDOAMm_X841Kwo9 github-actions[bot] 41898282 2021-08-03T17:05:30Z 2021-10-01T18:37:00Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   56m 54s :stopwatch: 16 228 tests 14 494 :heavy_check_mark: 1 734 :zzz: 0 :x: 90 564 runs  82 385 :heavy_check_mark: 8 179 :zzz: 0 :x:

Results for commit 0e75d8cc.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Combine='by_coords' and concat dim deprecation in open_mfdataset 959317311
932447036 https://github.com/pydata/xarray/pull/5669#issuecomment-932447036 https://api.github.com/repos/pydata/xarray/issues/5669 IC_kwDOAMm_X843lAM8 TomNicholas 35968931 2021-10-01T18:07:26Z 2021-10-01T18:07:26Z MEMBER

LGTM.

I've merged main, so will merge this as soon as the tests pass.

there might be value in accepting (and using) the dim argument also for combine_by_coords as there may be ambiguous cases where it could help #4824 (comment).

I don't think we should add dim to combine_by_coords - the whole philosophy of that function is that it uses only the information in the coordinates to do the combining. I would be more in favour of disallowing the arguments that lead to ambiguous outcomes. (But we should discuss this on #4824).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Combine='by_coords' and concat dim deprecation in open_mfdataset 959317311

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);