issue_comments: 932447036

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5669#issuecomment-932447036 https://api.github.com/repos/pydata/xarray/issues/5669 932447036 IC_kwDOAMm_X843lAM8 35968931 2021-10-01T18:07:26Z 2021-10-01T18:07:26Z MEMBER

LGTM.

I've merged main, so will merge this as soon as the tests pass.

there might be value in accepting (and using) the dim argument also for combine_by_coords as there may be ambiguous cases where it could help #4824 (comment).

I don't think we should add dim to combine_by_coords - the whole philosophy of that function is that it uses only the information in the coordinates to do the combining. I would be more in favour of disallowing the arguments that lead to ambiguous outcomes. (But we should discuss this on #4824).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   959317311