issue_comments

Table actions

11 rows where issue = 957439114 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Limit and format number of displayed dimensions in repr · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1003205657 https://github.com/pydata/xarray/pull/5662#issuecomment-1003205657 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X847y7QZ Illviljan 14371165 2021-12-30T22:56:42Z 2021-12-30T22:56:42Z MEMBER

I'll merge this in a couple of days unless someone minds.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
890483420 https://github.com/pydata/xarray/pull/5662#issuecomment-890483420 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X841E7Lc github-actions[bot] 41898282 2021-08-01T09:20:21Z 2021-10-31T23:05:56Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   53m 34s :stopwatch: 16 291 tests 14 559 :heavy_check_mark: 1 732 :zzz: 0 :x: 90 942 runs  82 751 :heavy_check_mark: 8 191 :zzz: 0 :x:

Results for commit e3af7c03.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
894144580 https://github.com/pydata/xarray/pull/5662#issuecomment-894144580 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X841S5BE pep8speaks 24736507 2021-08-06T09:50:29Z 2021-10-31T08:56:37Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-10-31 08:56:37 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
904159594 https://github.com/pydata/xarray/pull/5662#issuecomment-904159594 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X8415GFq Illviljan 14371165 2021-08-23T21:54:35Z 2021-08-23T21:54:35Z MEMBER

The 2 is not aligned with (coord39) because the Attributes part doesn't use col_width as input. Dimensions, Coordinates and Data variables uses it, but not attrs for some reason.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
904084591 https://github.com/pydata/xarray/pull/5662#issuecomment-904084591 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X8414zxv st-bender 28786187 2021-08-23T20:08:30Z 2021-08-23T20:11:26Z CONTRIBUTOR

@Illviljan Thanks for this comparison, I certainly prefer the second one, it looks better aligned to me and we get a little more information on one page. But then that's only me. ;)

Edit: Not sure what you mean with the attributes, they all start in the 5th column, after 4 spaces like the officially recommended python indentation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
904000203 https://github.com/pydata/xarray/pull/5662#issuecomment-904000203 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X8414fLL Illviljan 14371165 2021-08-23T18:13:54Z 2021-08-23T18:13:54Z MEMBER

It was easy enough to change so here's how it would look like with one of these extreme datasets:

Original: python <xarray.Dataset> Dimensions: (coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2, coord5: 2, coord6: 2, coord7: 2, coord8: 2, coord9: 2, coord10: 2, coord11: 2, coord12: 2, coord13: 2, coord14: 2, coord15: 2, coord16: 2, coord17: 2, coord18: 2, coord19: 2, coord20: 2, coord21: 2, coord22: 2, coord23: 2, coord24: 2, coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2, coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2, coord35: 2, coord36: 2, coord37: 2, coord38: 2, coord39: 2) Coordinates: (12/40) * coord0 (coord0) int32 0 1 * coord1 (coord1) int32 0 1 * coord2 (coord2) int32 0 1 * coord3 (coord3) int32 0 1 * coord4 (coord4) int32 0 1 * coord5 (coord5) int32 0 1 ... * coord34 (coord34) int32 0 1 * coord35 (coord35) int32 0 1 * coord36 (coord36) int32 0 1 * coord37 (coord37) int32 0 1 * coord38 (coord38) int32 0 1 * coord39 (coord39) int32 0 1 Data variables: (12/40) long_name0 (coord0) int32 3 4 long_name1 (coord1) int32 3 4 long_name2 (coord2) int32 3 4 long_name3 (coord3) int32 3 4 long_name4 (coord4) int32 3 4 long_name5 (coord5) int32 3 4 ... long_name34 (coord34) int32 3 4 long_name35 (coord35) int32 3 4 long_name36 (coord36) int32 3 4 long_name37 (coord37) int32 3 4 long_name38 (coord38) int32 3 4 long_name39 (coord39) int32 3 4 Attributes: (12/30) attr_0: 2 attr_1: 2 attr_2: 2 attr_3: 2 attr_4: 2 attr_5: 2 ... attr_24: 2 attr_25: 2 attr_26: 2 attr_27: 2 attr_28: 2 attr_29: 2

New line with some indent: python <xarray.Dataset> Dimensions: (coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2, coord5: 2, coord6: 2, coord7: 2, coord8: 2, coord9: 2, coord10: 2, coord11: 2, coord12: 2, coord13: 2, coord14: 2, coord15: 2, coord16: 2, coord17: 2, coord18: 2, coord19: 2, coord20: 2, coord21: 2, coord22: 2, coord23: 2, coord24: 2, coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2, coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2, coord35: 2, coord36: 2, coord37: 2, coord38: 2, coord39: 2) Coordinates: (12/40) * coord0 (coord0) int32 0 1 * coord1 (coord1) int32 0 1 * coord2 (coord2) int32 0 1 * coord3 (coord3) int32 0 1 * coord4 (coord4) int32 0 1 * coord5 (coord5) int32 0 1 ... * coord34 (coord34) int32 0 1 * coord35 (coord35) int32 0 1 * coord36 (coord36) int32 0 1 * coord37 (coord37) int32 0 1 * coord38 (coord38) int32 0 1 * coord39 (coord39) int32 0 1 Data variables: (12/40) long_name0 (coord0) int32 3 4 long_name1 (coord1) int32 3 4 long_name2 (coord2) int32 3 4 long_name3 (coord3) int32 3 4 long_name4 (coord4) int32 3 4 long_name5 (coord5) int32 3 4 ... long_name34 (coord34) int32 3 4 long_name35 (coord35) int32 3 4 long_name36 (coord36) int32 3 4 long_name37 (coord37) int32 3 4 long_name38 (coord38) int32 3 4 long_name39 (coord39) int32 3 4 Attributes: (12/30) attr_0: 2 attr_1: 2 attr_2: 2 attr_3: 2 attr_4: 2 attr_5: 2 ... attr_24: 2 attr_25: 2 attr_26: 2 attr_27: 2 attr_28: 2 attr_29: 2

No new line but small indent: python <xarray.Dataset> Dimensions: (coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2, coord5: 2, coord6: 2, coord7: 2, coord8: 2, coord9: 2, coord10: 2, coord11: 2, coord12: 2, coord13: 2, coord14: 2, coord15: 2, coord16: 2, coord17: 2, coord18: 2, coord19: 2, coord20: 2, coord21: 2, coord22: 2, coord23: 2, coord24: 2, coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2, coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2, coord35: 2, coord36: 2, coord37: 2, coord38: 2, coord39: 2) Coordinates: (12/40) * coord0 (coord0) int32 0 1 * coord1 (coord1) int32 0 1 * coord2 (coord2) int32 0 1 * coord3 (coord3) int32 0 1 * coord4 (coord4) int32 0 1 * coord5 (coord5) int32 0 1 ... * coord34 (coord34) int32 0 1 * coord35 (coord35) int32 0 1 * coord36 (coord36) int32 0 1 * coord37 (coord37) int32 0 1 * coord38 (coord38) int32 0 1 * coord39 (coord39) int32 0 1 Data variables: (12/40) long_name0 (coord0) int32 3 4 long_name1 (coord1) int32 3 4 long_name2 (coord2) int32 3 4 long_name3 (coord3) int32 3 4 long_name4 (coord4) int32 3 4 long_name5 (coord5) int32 3 4 ... long_name34 (coord34) int32 3 4 long_name35 (coord35) int32 3 4 long_name36 (coord36) int32 3 4 long_name37 (coord37) int32 3 4 long_name38 (coord38) int32 3 4 long_name39 (coord39) int32 3 4 Attributes: (12/30) attr_0: 2 attr_1: 2 attr_2: 2 attr_3: 2 attr_4: 2 attr_5: 2 ... attr_24: 2 attr_25: 2 attr_26: 2 attr_27: 2 attr_28: 2 attr_29: 2

I think I prefer the original one because of the alignment with the dims in coords and data variables.

The second one is nice, familiar format as Coordinates and will likely never get in to the 1 long dimension per row issue like in one of the examples. But it looks a little too dense now maybe? This is also adds an extra row for all cases which might not be necessary with most real life datasets? Dimensions without coordinates will add 1 extra row as well.

The 3rd one was an alternative to avoid a completely breaking change like the second one is. But I think it looks the worst of these alternatives, too messy. But it's similar to how it looks like right now if the console wraps the printed text.

On another note I'm slightly annoyed that the attribute values aren't aligning the same way as coords and data variables and I cannot unsee it now. :/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
903520910 https://github.com/pydata/xarray/pull/5662#issuecomment-903520910 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X8412qKO st-bender 28786187 2021-08-23T07:40:06Z 2021-08-23T07:40:06Z CONTRIBUTOR

The tests look good!

Any thoughts from anyone before we merge?

Looks good, but in my opinion this wastes some screen space on the left side. One could probably start a new line for the dimensions in a Dataset: python Dimensions: (long_coord_name_0_x: 20, long_coord_name_10_x: 20, ... or with some indenting: python Dimensions: (long_coord_name_0_x: 20, long_coord_name_10_x: 20, ... Maybe the same for the DataArray: python <xarray.DataArray 'LongDataArrayName' (dim_0: 2, dim_1: 2, dim_2: 2, dim_3: 2, dim_4: 2, dim_5: 2, dim_6: 2, dim_7: 2, dim_8: 2, dim_9: 2, dim_10: 2, dim_11: 2)> Just an idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
903354752 https://github.com/pydata/xarray/pull/5662#issuecomment-903354752 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X8412BmA max-sixty 5635139 2021-08-23T00:11:50Z 2021-08-23T00:11:50Z MEMBER

The tests look good!

Any thoughts from anyone before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
895850899 https://github.com/pydata/xarray/pull/5662#issuecomment-895850899 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X841ZZmT Illviljan 14371165 2021-08-10T08:51:25Z 2021-08-10T08:51:25Z MEMBER

=========================== short test summary info ============================ FAILED xarray/tests/test_formatting_html.py::test_repr_of_nonstr_dataarray - ...

I'm affecting html formattings now. That seems unnecessary.

https://github.com/pydata/xarray/blob/4bb9d9c6df77137f05e85c7cc6508fe7a93dc0e4/xarray/core/formatting_html.py#L255 Seems to be this line that caused the error. I don't understand what it does though, some backup of sorts?

If it's only being used as backup when something fails I think this is ready.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
894158453 https://github.com/pydata/xarray/pull/5662#issuecomment-894158453 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X841S8Z1 Illviljan 14371165 2021-08-06T10:13:51Z 2021-08-06T11:04:23Z MEMBER

Seems the OPTIONS dict isn't being correctly typed, mypy seems to think that OPTIONS["display_max_rows"] is a object somehow.

EDIT: This seems solvable using typeddict, https://stackoverflow.com/questions/48013561/how-to-use-static-type-checking-using-dict-with-different-value-types-in-python

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114
894175194 https://github.com/pydata/xarray/pull/5662#issuecomment-894175194 https://api.github.com/repos/pydata/xarray/issues/5662 IC_kwDOAMm_X841TAfa Illviljan 14371165 2021-08-06T10:47:04Z 2021-08-06T10:47:04Z MEMBER

=========================== short test summary info ============================ FAILED xarray/tests/test_formatting_html.py::test_repr_of_nonstr_dataarray - ... I'm affecting html formattings now. That seems unnecessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Limit and format number of displayed dimensions in repr 957439114

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);