home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 903520910

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5662#issuecomment-903520910 https://api.github.com/repos/pydata/xarray/issues/5662 903520910 IC_kwDOAMm_X8412qKO 28786187 2021-08-23T07:40:06Z 2021-08-23T07:40:06Z CONTRIBUTOR

The tests look good!

Any thoughts from anyone before we merge?

Looks good, but in my opinion this wastes some screen space on the left side. One could probably start a new line for the dimensions in a Dataset: python Dimensions: (long_coord_name_0_x: 20, long_coord_name_10_x: 20, ... or with some indenting: python Dimensions: (long_coord_name_0_x: 20, long_coord_name_10_x: 20, ... Maybe the same for the DataArray: python <xarray.DataArray 'LongDataArrayName' (dim_0: 2, dim_1: 2, dim_2: 2, dim_3: 2, dim_4: 2, dim_5: 2, dim_6: 2, dim_7: 2, dim_8: 2, dim_9: 2, dim_10: 2, dim_11: 2)> Just an idea.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  957439114
Powered by Datasette · Queries took 0.713ms · About: xarray-datasette