issue_comments

Table actions

19 rows where issue = 945434599 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 4

issue 1

  • Kwargs to rasterio open · 19 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
880758601 https://github.com/pydata/xarray/pull/5609#issuecomment-880758601 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDc1ODYwMQ== github-actions[bot] 41898282 2021-07-15T14:50:24Z 2021-07-30T07:28:40Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   48m 44s :stopwatch: ±0s 16 200 tests ±0  14 475 :heavy_check_mark: ±0  1 725 :zzz: ±0  0 :x: ±0  90 396 runs  ±0  82 231 :heavy_check_mark: ±0  8 165 :zzz: ±0  0 :x: ±0 

Results for commit 78cec7c5. ± Comparison against base commit 78cec7c5.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
889686492 https://github.com/pydata/xarray/pull/5609#issuecomment-889686492 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X841B4nc pkopparla 76039838 2021-07-30T07:19:19Z 2021-07-30T07:19:19Z CONTRIBUTOR

Thanks for leading me through the process @keewis , it's my first code contribution to any open-source project. Hope to do more in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
889681208 https://github.com/pydata/xarray/pull/5609#issuecomment-889681208 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X841B3U4 keewis 14808389 2021-07-30T07:09:10Z 2021-07-30T07:09:10Z MEMBER

Thanks, @pkopparla. I also noticed this is your first PR here. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887381034 https://github.com/pydata/xarray/pull/5609#issuecomment-887381034 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8405Fwq keewis 14808389 2021-07-27T10:02:21Z 2021-07-27T10:02:21Z MEMBER

thanks for the update, @pkopparla. I'll merge this tomorrow if there are no further comments.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887356235 https://github.com/pydata/xarray/pull/5609#issuecomment-887356235 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404_tL pkopparla 76039838 2021-07-27T09:24:10Z 2021-07-27T09:24:10Z CONTRIBUTOR

@keewis Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880735542 https://github.com/pydata/xarray/pull/5609#issuecomment-880735542 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDczNTU0Mg== pep8speaks 24736507 2021-07-15T14:21:06Z 2021-07-27T09:23:28Z NONE

Hello @pkopparla! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-07-27 09:23:27 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887324339 https://github.com/pydata/xarray/pull/5609#issuecomment-887324339 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X840436z aurghs 35919497 2021-07-27T08:37:35Z 2021-07-27T08:38:30Z COLLABORATOR

I would try to stay as close to open_dataset as possible, which would make migrating to rioxarray's engine easier once we deprecate open_rasterio. If I understand the signature of open_dataset correctly, this is called backend_kwargs?

The idea was to deprecate in the future open_dataset backend_kwargs. Currently, in open_dataset signature, you can use either backend_kwargs or kwargs to pass the backend additional parameters. I would avoid adding backend_kwargs in open_rasterio interface.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887315650 https://github.com/pydata/xarray/pull/5609#issuecomment-887315650 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X84041zC keewis 14808389 2021-07-27T08:24:34Z 2021-07-27T08:24:34Z MEMBER

no, this is fine, and the PR looks good to me. I'd say let's wait one more day to give more time for reviews and then merge by tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887305146 https://github.com/pydata/xarray/pull/5609#issuecomment-887305146 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404zO6 pkopparla 76039838 2021-07-27T08:09:27Z 2021-07-27T08:10:14Z CONTRIBUTOR

@keewis thanks! Looks like most checks are successful now. Is there anything further I should do? Should I close the pull request?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887286544 https://github.com/pydata/xarray/pull/5609#issuecomment-887286544 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404usQ keewis 14808389 2021-07-27T07:40:24Z 2021-07-27T07:40:24Z MEMBER

this has been fixed / worked around on main, so the merge should have fixed it

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887282590 https://github.com/pydata/xarray/pull/5609#issuecomment-887282590 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404tue pkopparla 76039838 2021-07-27T07:33:27Z 2021-07-27T07:33:27Z CONTRIBUTOR

@dcherian @keewis Hey guys, a backend test is failing but I'm not sure why or how my change is affecting it. Would be grateful for a pointer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
881283746 https://github.com/pydata/xarray/pull/5609#issuecomment-881283746 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X840h1Ki pkopparla 76039838 2021-07-16T08:47:00Z 2021-07-16T08:47:00Z CONTRIBUTOR

Looks like the backend_kwargs argument is breaking the function. Should I just get rid of it and leave in **kwargs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
881233598 https://github.com/pydata/xarray/pull/5609#issuecomment-881233598 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X840ho6- pkopparla 76039838 2021-07-16T07:19:24Z 2021-07-16T07:19:24Z CONTRIBUTOR

Thanks everyone for the feedback. I've added a backend_kwargs and a **kwargs argument following the xarray.open_dataset style.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880914020 https://github.com/pydata/xarray/pull/5609#issuecomment-880914020 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDkxNDAyMA== snowman2 8699967 2021-07-15T18:18:43Z 2021-07-15T18:18:43Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880870712 https://github.com/pydata/xarray/pull/5609#issuecomment-880870712 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDg3MDcxMg== keewis 14808389 2021-07-15T17:10:29Z 2021-07-15T17:10:29Z MEMBER

right, it seems it's both backend_kwargs and **kwargs for open_dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880840290 https://github.com/pydata/xarray/pull/5609#issuecomment-880840290 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDg0MDI5MA== dcherian 2448579 2021-07-15T16:26:18Z 2021-07-15T16:26:18Z MEMBER

rioxarray.open_rasterio (and xr.open_zarr) uses the **kwargs format, so maybe that's the model to follow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880812923 https://github.com/pydata/xarray/pull/5609#issuecomment-880812923 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDgxMjkyMw== keewis 14808389 2021-07-15T15:56:06Z 2021-07-15T15:56:06Z MEMBER

I would try to stay as close to open_dataset as possible, which would make migrating to rioxarray's engine easier once we deprecate open_rasterio. If I understand the signature of open_dataset correctly, this is called backend_kwargs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880800433 https://github.com/pydata/xarray/pull/5609#issuecomment-880800433 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDgwMDQzMw== pkopparla 76039838 2021-07-15T15:39:04Z 2021-07-15T15:44:10Z CONTRIBUTOR

Should this pass **kwargs through rather than take an explicit kwargs arg?

I am not sure about the nuances here, but the linked issue shows a h5netcdf function that follows the same pattern.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880783738 https://github.com/pydata/xarray/pull/5609#issuecomment-880783738 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDc4MzczOA== max-sixty 5635139 2021-07-15T15:18:48Z 2021-07-15T15:18:48Z MEMBER

Should this pass **kwargs through rather than take an explicit kwargs arg?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);