issue_comments

Table actions

3 rows where issue = 94417601 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • jhamman · 3 ✖

issue 1

  • Feature plotting · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
122576123 https://github.com/pydata/xarray/pull/466#issuecomment-122576123 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjU3NjEyMw== jhamman 2443309 2015-07-18T18:30:16Z 2015-07-18T18:30:16Z MEMBER

@clarkfitzg - I just spent some time running through your examples and trying to plot some of my own data. Overall - this is really slick and I really liked what you have going here. Below are a few comments I made along the way - take them or leave them. 1. Consider yincrease=True as the default. Maybe there is a downside to this but I don't see it. I'm pretty sure it is just the convention of imshow. 2. It may be worth mentioning why you are using imshow over pcolormesh. The limitation of imshow having regularly spaced coordinates will be important to some (myself included). We may, at some point, want to add an option for using pcolormesh. This would support irregular grids without forcing the use of contourf. 3. More examples with cartopy would be good. Maybe we can put together example page here: http://xray.readthedocs.org/en/latest/examples.html 4. I continue to have cartopy install problems on osx, even with python2.7 using anaconda. I also had problems on a clean docker image. I know this has nothing to do with this PR but the problems with installing cartopy will limit its applicability here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601
122489008 https://github.com/pydata/xarray/pull/466#issuecomment-122489008 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjQ4OTAwOA== jhamman 2443309 2015-07-18T06:02:59Z 2015-07-18T06:02:59Z MEMBER

yeah, +1 for the viridis colormap.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601
122480887 https://github.com/pydata/xarray/pull/466#issuecomment-122480887 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjQ4MDg4Nw== jhamman 2443309 2015-07-18T04:19:17Z 2015-07-18T04:19:17Z MEMBER

I'm going to get around to testing this out tomorrow. I just breezed through the docs and I have one comment. Can we not use jet as the default colormap? I know it is the default colormap in matplotlib but we aren't bound by that. There are dozens of sources out there explaining why jet is a bad choice. I'll give two of the ones that have popped out to me over the years: - https://jakevdp.github.io/blog/2014/10/16/how-bad-is-your-colormap/ - http://web.stanford.edu/~mwaskom/software/seaborn/tutorial/color_palettes.html

There is also a lively Github issue over here: https://github.com/matplotlib/matplotlib/issues/875

I'll try to get a few more comments out tomorrow. So far, this work is really encouraging. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);