issue_comments: 122576123

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/466#issuecomment-122576123 https://api.github.com/repos/pydata/xarray/issues/466 122576123 MDEyOklzc3VlQ29tbWVudDEyMjU3NjEyMw== 2443309 2015-07-18T18:30:16Z 2015-07-18T18:30:16Z MEMBER

@clarkfitzg - I just spent some time running through your examples and trying to plot some of my own data. Overall - this is really slick and I really liked what you have going here. Below are a few comments I made along the way - take them or leave them. 1. Consider yincrease=True as the default. Maybe there is a downside to this but I don't see it. I'm pretty sure it is just the convention of imshow. 2. It may be worth mentioning why you are using imshow over pcolormesh. The limitation of imshow having regularly spaced coordinates will be important to some (myself included). We may, at some point, want to add an option for using pcolormesh. This would support irregular grids without forcing the use of contourf. 3. More examples with cartopy would be good. Maybe we can put together example page here: http://xray.readthedocs.org/en/latest/examples.html 4. I continue to have cartopy install problems on osx, even with python2.7 using anaconda. I also had problems on a clean docker image. I know this has nothing to do with this PR but the problems with installing cartopy will limit its applicability here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   94417601