issue_comments

Table actions

7 rows where issue = 925664972 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Use integer type hints in chunk functions · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
864802881 https://github.com/pydata/xarray/pull/5502#issuecomment-864802881 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDgwMjg4MQ== github-actions[bot] 41898282 2021-06-21T07:37:33Z 2021-06-21T07:37:33Z CONTRIBUTOR

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a7362831. ± Comparison against base commit a7362831.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864787454 https://github.com/pydata/xarray/pull/5502#issuecomment-864787454 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDc4NzQ1NA== max-sixty 5635139 2021-06-21T07:10:40Z 2021-06-21T07:10:40Z MEMBER

Thanks a lot again @Illviljan !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864786991 https://github.com/pydata/xarray/pull/5502#issuecomment-864786991 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDc4Njk5MQ== max-sixty 5635139 2021-06-21T07:09:55Z 2021-06-21T07:09:55Z MEMBER

The docs failure is actually (the output is very hard to scan quickly):

/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/5502/doc/whats-new.rst:725: WARNING: unknown document: io

...which is also unrelated...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864745252 https://github.com/pydata/xarray/pull/5502#issuecomment-864745252 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDc0NTI1Mg== Illviljan 14371165 2021-06-21T05:44:45Z 2021-06-21T05:44:45Z MEMBER

Doc errors seems unrelated or? Only warning I found was this:

waiting for workers... /home/docs/checkouts/readthedocs.org/user_builds/xray/conda/5502/lib/python3.8/site-packages/cartopy/io/__init__.py:241: DownloadWarning: Downloading: https://naciscdn.org/naturalearth/50m/physical/ne_50m_coastline.zip warnings.warn('Downloading: {}'.format(url), DownloadWarning) /home/docs/checkouts/readthedocs.org/user_builds/xray/conda/5502/lib/python3.8/site-packages/cartopy/mpl/gridliner.py:760: UserWarning: The labels of this gridliner do not belong to the gridliner axes warnings.warn('The labels of this gridliner do not belong to ' looking for now-outdated files... none found pickling environment... done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864618417 https://github.com/pydata/xarray/pull/5502#issuecomment-864618417 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDYxODQxNw== max-sixty 5635139 2021-06-20T22:13:08Z 2021-06-20T22:13:08Z MEMBER

Right — isinstance(1, (Number, str, int)) will return true because it's at least one of those. I think that's fine.

Also fine to coerce any Number to int in the chunk method. We probably do want to allow 2.0 to work in the API, but we can coerce to ints and then internally only use int.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864602759 https://github.com/pydata/xarray/pull/5502#issuecomment-864602759 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDYwMjc1OQ== Illviljan 14371165 2021-06-20T19:45:00Z 2021-06-20T19:45:00Z MEMBER

Not sure how isinstance works. Would it stop once it finds a match? So isinstance(1, (Number, str, int)) would always stop at Number?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972
864601129 https://github.com/pydata/xarray/pull/5502#issuecomment-864601129 https://api.github.com/repos/pydata/xarray/issues/5502 MDEyOklzc3VlQ29tbWVudDg2NDYwMTEyOQ== Illviljan 14371165 2021-06-20T19:30:11Z 2021-06-20T19:30:11Z MEMBER

Once again with these false positives: xarray/core/dataset.py:2138: error: Item "int" of "Union[int, Mapping[Hashable, Union[None, int, str, Tuple[int, ...]]]]" has no attribute "keys" [union-attr]

It's checked one row above this error where Number works as intended...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use integer type hints in chunk functions  925664972

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);