home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 864618417

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5502#issuecomment-864618417 https://api.github.com/repos/pydata/xarray/issues/5502 864618417 MDEyOklzc3VlQ29tbWVudDg2NDYxODQxNw== 5635139 2021-06-20T22:13:08Z 2021-06-20T22:13:08Z MEMBER

Right — isinstance(1, (Number, str, int)) will return true because it's at least one of those. I think that's fine.

Also fine to coerce any Number to int in the chunk method. We probably do want to allow 2.0 to work in the API, but we can coerce to ints and then internally only use int.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  925664972
Powered by Datasette · Queries took 241.146ms · About: xarray-datasette