issue_comments

Table actions

7 rows where issue = 912932344 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add `xr.unify_chunks()` top level method · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
862472350 https://github.com/pydata/xarray/pull/5445#issuecomment-862472350 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg2MjQ3MjM1MA== github-actions[bot] 41898282 2021-06-16T15:21:59Z 2021-06-16T15:21:59Z CONTRIBUTOR

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit fe87162c. ± Comparison against base commit fe87162c.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
862452176 https://github.com/pydata/xarray/pull/5445#issuecomment-862452176 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg2MjQ1MjE3Ng== dcherian 2448579 2021-06-16T14:56:53Z 2021-06-16T14:56:53Z MEMBER

Thanks @malmans2 and @crusaderky!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
861703938 https://github.com/pydata/xarray/pull/5445#issuecomment-861703938 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg2MTcwMzkzOA== dcherian 2448579 2021-06-15T17:41:53Z 2021-06-15T17:41:53Z MEMBER

Ya I think it's OK for this function

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
861454733 https://github.com/pydata/xarray/pull/5445#issuecomment-861454733 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg2MTQ1NDczMw== crusaderky 6213168 2021-06-15T12:25:58Z 2021-06-15T12:25:58Z MEMBER

LGTM. Note that the function doesn't align indices. e.g. if you have:

python a = DataArray([0,1,2,3], dims=["x"], coords={"x": [0,10,20,30]}).chunk(3) b = DataArray([0,1,2,3], dims=["x"], coords={"x": [10,30,40,50]}).chunk(2) a, b = unify_chunks(a, b) You'll end up with aligned chunks, but not aligned coords (e.g. both outputs have still values=[0,1,2,3]), which doesn't make much sense. I think this is OK to leave it as it is in this specific case the issue should not do much harm anyway and it would just be a slowdown in most cases; I'd like to hear @dcherian's or @jhamman's opinions though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
855453107 https://github.com/pydata/xarray/pull/5445#issuecomment-855453107 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg1NTQ1MzEwNw== pep8speaks 24736507 2021-06-06T19:51:55Z 2021-06-15T12:11:39Z NONE

Hello @malmans2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-06-15 12:11:39 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
860750129 https://github.com/pydata/xarray/pull/5445#issuecomment-860750129 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg2MDc1MDEyOQ== malmans2 22245117 2021-06-14T14:54:10Z 2021-06-14T14:54:10Z CONTRIBUTOR

Thanks @crusaderky! I think all your suggestions are now implemented.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344
859234848 https://github.com/pydata/xarray/pull/5445#issuecomment-859234848 https://api.github.com/repos/pydata/xarray/issues/5445 MDEyOklzc3VlQ29tbWVudDg1OTIzNDg0OA== jhamman 2443309 2021-06-11T03:26:15Z 2021-06-11T03:26:15Z MEMBER

pinging @dcherian and/or @crusaderky who may have thoughts on this PR. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `xr.unify_chunks()` top level method 912932344

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);