issue_comments: 861454733

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5445#issuecomment-861454733 https://api.github.com/repos/pydata/xarray/issues/5445 861454733 MDEyOklzc3VlQ29tbWVudDg2MTQ1NDczMw== 6213168 2021-06-15T12:25:58Z 2021-06-15T12:25:58Z MEMBER

LGTM. Note that the function doesn't align indices. e.g. if you have:

python a = DataArray([0,1,2,3], dims=["x"], coords={"x": [0,10,20,30]}).chunk(3) b = DataArray([0,1,2,3], dims=["x"], coords={"x": [10,30,40,50]}).chunk(2) a, b = unify_chunks(a, b) You'll end up with aligned chunks, but not aligned coords (e.g. both outputs have still values=[0,1,2,3]), which doesn't make much sense. I think this is OK to leave it as it is in this specific case the issue should not do much harm anyway and it would just be a slowdown in most cases; I'd like to hear @dcherian's or @jhamman's opinions though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   912932344