issue_comments

Table actions

13 rows where issue = 908651787 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Error concat dataset and dataarray · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
855030132 https://github.com/pydata/xarray/pull/5425#issuecomment-855030132 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NTAzMDEzMg== max-sixty 5635139 2021-06-04T22:05:25Z 2021-06-04T22:05:25Z MEMBER

Excellent, thank you for the contribution @thomashirtz . We're happy to have you as a contributor.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
854940045 https://github.com/pydata/xarray/pull/5425#issuecomment-854940045 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NDk0MDA0NQ== thomashirtz 37740986 2021-06-04T19:00:58Z 2021-06-04T19:00:58Z CONTRIBUTOR

Yes I understand now I committed myself to do the last minor adjustment on github, I really should not have facepalm (pre-commit is great)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
853629562 https://github.com/pydata/xarray/pull/5425#issuecomment-853629562 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MzYyOTU2Mg== pep8speaks 24736507 2021-06-03T07:06:50Z 2021-06-04T18:56:37Z NONE

Hello @thomashirtz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-06-04 18:56:36 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
854927637 https://github.com/pydata/xarray/pull/5425#issuecomment-854927637 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NDkyNzYzNw== max-sixty 5635139 2021-06-04T18:35:53Z 2021-06-04T18:35:53Z MEMBER

@thomashirtz not sure if it was my mistake or a GitHub bug, but looks like my reply to you overwrote a message of yours.

I was intending to say you could edit the whatsnew in the same way you edit the code, and then commit those changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
854195877 https://github.com/pydata/xarray/pull/5425#issuecomment-854195877 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NDE5NTg3Nw== max-sixty 5635139 2021-06-03T21:35:01Z 2021-06-03T21:35:01Z MEMBER

Great! Did you commit the whatsnew?

The commit message is the title of the PR!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
854127828 https://github.com/pydata/xarray/pull/5425#issuecomment-854127828 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NDEyNzgyOA== thomashirtz 37740986 2021-06-03T19:39:42Z 2021-06-03T19:49:01Z CONTRIBUTOR

Ha, no problem. And don't worry about the commit quality — it's all squashed into one at the end. I generally write one good message at the start but that's all.

Good that they are going to be squashed, because this PR starts to look very much chaotic ah ah
So when they are squashed, the message of the first commit get automatically picked ?

One small change — could we say in the error message that they all need to be either all DataArrays or all Datasets? For a new user, the currently proposed messages could suggest that they all need to be the type in the message, and that type is determined by the order of the args, which is a bit confusing. That might mean the error message is the same for both, or only slightly different. Does that make sense?

It does make sense
Done ✔

I also edited whats new

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
854047989 https://github.com/pydata/xarray/pull/5425#issuecomment-854047989 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1NDA0Nzk4OQ== max-sixty 5635139 2021-06-03T17:25:18Z 2021-06-03T17:25:18Z MEMBER

Ha, no problem. And don't worry about the commit quality — it's all squashed into one at the end. I generally write one good message at the start but that's all.

This looks good now!

One small change — could we say in the error message that they all need to be either all DataArrays or all Datasets? For a new user, the currently proposed messages could suggest that they all need to be the type in the message, and that type is determined by the order of the args, which is a bit confusing. That might mean the error message is the same for both, or only slightly different. Does that make sense?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
853634406 https://github.com/pydata/xarray/pull/5425#issuecomment-853634406 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MzYzNDQwNg== thomashirtz 37740986 2021-06-03T07:13:57Z 2021-06-03T07:20:05Z CONTRIBUTOR

Oh, I just found, I wanted to do three separate commits for each changes, but when I did the dataarray commit, I somehow reverted the changes of the dataset commit facepalm. All the tests were working on my computer because I still had the changes locally. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
853349631 https://github.com/pydata/xarray/pull/5425#issuecomment-853349631 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MzM0OTYzMQ== max-sixty 5635139 2021-06-02T20:09:02Z 2021-06-02T20:09:02Z MEMBER

Taking a quick look, where's the code that should match match="Some elements in the input list datasets are not 'Dataset'"? I see it works for DataArray, but does it for Dataset?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
853345364 https://github.com/pydata/xarray/pull/5425#issuecomment-853345364 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MzM0NTM2NA== thomashirtz 37740986 2021-06-02T20:01:43Z 2021-06-02T20:02:24Z CONTRIBUTOR

Ok I'll do the whatsnew soon :) I am a little bit stuck though, I don't really found why my test would cause a ValueError in those tests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
852456735 https://github.com/pydata/xarray/pull/5425#issuecomment-852456735 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MjQ1NjczNQ== max-sixty 5635139 2021-06-01T21:26:47Z 2021-06-01T21:26:47Z MEMBER

Add an entry here — copy another entry and edit it, since it cares about the format of the text — https://github.com/pydata/xarray/blob/master/doc/whats-new.rst.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
852441855 https://github.com/pydata/xarray/pull/5425#issuecomment-852441855 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MjQ0MTg1NQ== thomashirtz 37740986 2021-06-01T21:00:47Z 2021-06-01T21:00:47Z CONTRIBUTOR

This looks great! Do you want to add a note to the whatsnew?

What is the whatsnew ? I am still checking why there is some test failing 😶

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787
852426104 https://github.com/pydata/xarray/pull/5425#issuecomment-852426104 https://api.github.com/repos/pydata/xarray/issues/5425 MDEyOklzc3VlQ29tbWVudDg1MjQyNjEwNA== max-sixty 5635139 2021-06-01T20:32:04Z 2021-06-01T20:32:04Z MEMBER

This looks great! Do you want to add a note to the whatsnew?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error concat dataset and dataarray 908651787

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);