issue_comments: 854127828

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5425#issuecomment-854127828 https://api.github.com/repos/pydata/xarray/issues/5425 854127828 MDEyOklzc3VlQ29tbWVudDg1NDEyNzgyOA== 37740986 2021-06-03T19:39:42Z 2021-06-03T19:49:01Z CONTRIBUTOR

Ha, no problem. And don't worry about the commit quality — it's all squashed into one at the end. I generally write one good message at the start but that's all.

Good that they are going to be squashed, because this PR starts to look very much chaotic ah ah
So when they are squashed, the message of the first commit get automatically picked ?

One small change — could we say in the error message that they all need to be either all DataArrays or all Datasets? For a new user, the currently proposed messages could suggest that they all need to be the type in the message, and that type is determined by the order of the args, which is a bit confusing. That might mean the error message is the same for both, or only slightly different. Does that make sense?

It does make sense
Done ✔

I also edited whats new

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   908651787