issue_comments

Table actions

2 rows where issue = 907845790 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Does the PyPI release job fire twice for each release? · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
852309442 https://github.com/pydata/xarray/issues/5413#issuecomment-852309442 https://api.github.com/repos/pydata/xarray/issues/5413 MDEyOklzc3VlQ29tbWVudDg1MjMwOTQ0Mg== max-sixty 5635139 2021-06-01T17:28:33Z 2021-06-01T17:28:33Z MEMBER

Ah I see, thank you for explaining @andersy005 , I see now. This is excellent.

If we want to split out "Upload to TestPyPI" as its own job (rather than step) — so it's otherwise the same as "Upload to PyPI" but only runs on the tag, I'm happy to make that change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Does the PyPI release job fire twice for each release? 907845790
851835152 https://github.com/pydata/xarray/issues/5413#issuecomment-851835152 https://api.github.com/repos/pydata/xarray/issues/5413 MDEyOklzc3VlQ29tbWVudDg1MTgzNTE1Mg== andersy005 13301940 2021-06-01T05:49:42Z 2021-06-01T05:49:42Z MEMBER

Do we fire twice for each release? Maybe that's fine though?

Yes, on both push and release events. The publication to PyPI step is only run for the release event though i.e. if one were to push a tag to GitHub, this tag would never be published to PyPI via the GitHub workflow.

It's my understanding that

  • We could remove the push trigger and only keep the release trigger and everything would still work fine.
  • Having the two triggers comes in handy when/if one pushes tags via git (for testing purposes). As far as I can remember, @keewis was using the push event (via tags) to test the early versions of the workflow. 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Does the PyPI release job fire twice for each release? 907845790

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);