issue_comments: 851835152

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5413#issuecomment-851835152 https://api.github.com/repos/pydata/xarray/issues/5413 851835152 MDEyOklzc3VlQ29tbWVudDg1MTgzNTE1Mg== 13301940 2021-06-01T05:49:42Z 2021-06-01T05:49:42Z MEMBER

Do we fire twice for each release? Maybe that's fine though?

Yes, on both push and release events. The publication to PyPI step is only run for the release event though i.e. if one were to push a tag to GitHub, this tag would never be published to PyPI via the GitHub workflow.

It's my understanding that

  • We could remove the push trigger and only keep the release trigger and everything would still work fine.
  • Having the two triggers comes in handy when/if one pushes tags via git (for testing purposes). As far as I can remember, @keewis was using the push event (via tags) to test the early versions of the workflow. 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   907845790