issue_comments

Table actions

2 rows where issue = 905848466 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • max-sixty · 2 ✖

issue 1

  • Add type checking when concat · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
851624047 https://github.com/pydata/xarray/pull/5397#issuecomment-851624047 https://api.github.com/repos/pydata/xarray/issues/5397 MDEyOklzc3VlQ29tbWVudDg1MTYyNDA0Nw== max-sixty 5635139 2021-05-31T18:15:20Z 2021-05-31T18:15:20Z MEMBER

Will it not cripple performance due to the non-lazy evaluation of the list ?

I don't think so, but I'm not sure — keeping the full list in memory isn't expensive at all IIUC. And either way, it'll confirm the reason for the test failures for now.

I also started the test for the concat function, I discovered that if the first element determine between _dataarray_concat and _dataset_concat. I am not sure if I need to do several commits (type checking dataset, type checking data array) and several test.

Here is the draft for the tests:

Those look good! Feel free to add them directly and we can discuss them there, and see the test results. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add type checking when concat 905848466
850662147 https://github.com/pydata/xarray/pull/5397#issuecomment-850662147 https://api.github.com/repos/pydata/xarray/issues/5397 MDEyOklzc3VlQ29tbWVudDg1MDY2MjE0Nw== max-sixty 5635139 2021-05-28T20:47:48Z 2021-05-28T20:47:48Z MEMBER

Hi @thomashirtz ! Thanks for the PR.

The code looks reasonable, though it's generating test failures. To prioritize giving quick feedback over complete feedback — possibly datasets is sometimes a generator. We could add datasets = list(datasets) above the current code. If that doesn't fix it, feel free to take an error and try debugging what's going on, or someone can help.

We should add a test for this too.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add type checking when concat 905848466

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);