issue_comments: 850662147

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5397#issuecomment-850662147 https://api.github.com/repos/pydata/xarray/issues/5397 850662147 MDEyOklzc3VlQ29tbWVudDg1MDY2MjE0Nw== 5635139 2021-05-28T20:47:48Z 2021-05-28T20:47:48Z MEMBER

Hi @thomashirtz ! Thanks for the PR.

The code looks reasonable, though it's generating test failures. To prioritize giving quick feedback over complete feedback — possibly datasets is sometimes a generator. We could add datasets = list(datasets) above the current code. If that doesn't fix it, feel free to take an error and try debugging what's going on, or someone can help.

We should add a test for this too.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   905848466