issue_comments

Table actions

3 rows where issue = 896002237 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 3 ✖

issue 1

  • prefer the objects _repr_inline_ over xarray's custom reprs · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
848019023 https://github.com/pydata/xarray/pull/5352#issuecomment-848019023 https://api.github.com/repos/pydata/xarray/issues/5352 MDEyOklzc3VlQ29tbWVudDg0ODAxOTAyMw== shoyer 1217238 2021-05-25T16:18:57Z 2021-05-25T16:18:57Z MEMBER

in any case, I think any changes to the signature of _repr_inline_ should be a separate PR

I agree, let's discuss this in https://github.com/pydata/xarray/issues/5372

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   prefer the objects _repr_inline_ over xarray's custom reprs 896002237
846454152 https://github.com/pydata/xarray/pull/5352#issuecomment-846454152 https://api.github.com/repos/pydata/xarray/issues/5352 MDEyOklzc3VlQ29tbWVudDg0NjQ1NDE1Mg== shoyer 1217238 2021-05-22T19:36:07Z 2021-05-22T19:36:07Z MEMBER

It's more that _repr_inline_ sounds very generic, neither really specific to xarray or even multi-dimensional arrays. So if I saw that without knowing the context of how it is used in xarray, it would surprise me that it's supposed to omit shape and dtype, which are otherwise essential parts of the repr.

Other possibilities: - Give the protocol a namespace, like _xarray_repr_inline_ to make it clearer that it's for Xarray's use. - Maybe add an omit argument, e.g., obj._repr_inline_(max_width, skip=['dtype', 'shape']). Attributes in skip are already represented elsewhere and can be skipped if desired.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   prefer the objects _repr_inline_ over xarray's custom reprs 896002237
846075001 https://github.com/pydata/xarray/pull/5352#issuecomment-846075001 https://api.github.com/repos/pydata/xarray/issues/5352 MDEyOklzc3VlQ29tbWVudDg0NjA3NTAwMQ== shoyer 1217238 2021-05-21T16:16:09Z 2021-05-21T16:16:09Z MEMBER

I wonder if _repr_inline_ should include something explicit about excluded fields in the protocol, e.g., obj._repr_inline_(shape=False, dtype=False) and/or if the name should make it clearer that it's for array objects, e.g., _ndarray_repr_inline_?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   prefer the objects _repr_inline_ over xarray's custom reprs 896002237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);