issue_comments: 846454152

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5352#issuecomment-846454152 https://api.github.com/repos/pydata/xarray/issues/5352 846454152 MDEyOklzc3VlQ29tbWVudDg0NjQ1NDE1Mg== 1217238 2021-05-22T19:36:07Z 2021-05-22T19:36:07Z MEMBER

It's more that _repr_inline_ sounds very generic, neither really specific to xarray or even multi-dimensional arrays. So if I saw that without knowing the context of how it is used in xarray, it would surprise me that it's supposed to omit shape and dtype, which are otherwise essential parts of the repr.

Other possibilities: - Give the protocol a namespace, like _xarray_repr_inline_ to make it clearer that it's for Xarray's use. - Maybe add an omit argument, e.g., obj._repr_inline_(max_width, skip=['dtype', 'shape']). Attributes in skip are already represented elsewhere and can be skipped if desired.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   896002237