issue_comments

Table actions

3 rows where issue = 895202415 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 3 ✖

issue 1

  • test_push_dask fails type inference · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
848943156 https://github.com/pydata/xarray/issues/5342#issuecomment-848943156 https://api.github.com/repos/pydata/xarray/issues/5342 MDEyOklzc3VlQ29tbWVudDg0ODk0MzE1Ng== dcherian 2448579 2021-05-26T16:52:50Z 2021-05-26T16:52:50Z MEMBER

We should still make the changes proposed in https://github.com/pydata/xarray/issues/5342#issuecomment-844104261

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_push_dask fails type inference 895202415
845247492 https://github.com/pydata/xarray/issues/5342#issuecomment-845247492 https://api.github.com/repos/pydata/xarray/issues/5342 MDEyOklzc3VlQ29tbWVudDg0NTI0NzQ5Mg== dcherian 2448579 2021-05-20T16:01:50Z 2021-05-20T16:01:50Z MEMBER

What version of bottleneck are you testing it with? We require bottleneck >=1.3 (https://github.com/pydata/xarray/blob/master/ci/requirements/py37-min-all-deps.yml)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_push_dask fails type inference 895202415
844104261 https://github.com/pydata/xarray/issues/5342#issuecomment-844104261 https://api.github.com/repos/pydata/xarray/issues/5342 MDEyOklzc3VlQ29tbWVudDg0NDEwNDI2MQ== dcherian 2448579 2021-05-19T13:25:25Z 2021-05-19T13:25:25Z MEMBER

Thanks. This is a new test.

Here's where the error is triggered: https://github.com/pydata/xarray/blob/f3794ab1a75560f797b824c8c2d434aa65e7dd7d/xarray/core/dask_array_ops.py#L69-L73

We should specify both dtype and meta in the map_* calls like this:

python pushed = array.map_blocks(push, axis=axis, n=n, dtype=array.dtype, meta=array._meta) if len(array.chunks[axis]) > 1: pushed = pushed.map_overlap( push, axis=axis, n=n, depth={axis: (1, 0)}, boundary="none", dtype=array.dtype, meta=array._meta )

Can you send in a PR please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_push_dask fails type inference 895202415

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);