issue_comments

Table actions

6 rows where issue = 894753913 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Properly infer intervals of pcolormesh when plotting on logscale · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
873140890 https://github.com/pydata/xarray/pull/5334#issuecomment-873140890 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg3MzE0MDg5MA== santisoler 11541317 2021-07-02T17:08:58Z 2021-07-02T17:09:04Z CONTRIBUTOR

Thanks @dcherian! I really liked the PR process in xarray, having 3 reviewers here was awesome and a crucial part for building quality code. Thanks for your hard work and comments! Hope this to be the first PR of many more!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913
872968758 https://github.com/pydata/xarray/pull/5334#issuecomment-872968758 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg3Mjk2ODc1OA== dcherian 2448579 2021-07-02T12:42:31Z 2021-07-02T12:42:31Z MEMBER

I think we can address any concerns about test fixtures in a future PR.

Thanks @santisoler. I see this is your first contribution. welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913
856195015 https://github.com/pydata/xarray/pull/5334#issuecomment-856195015 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg1NjE5NTAxNQ== santisoler 11541317 2021-06-07T19:21:54Z 2021-06-07T19:21:54Z CONTRIBUTOR

@shoyer I've just fixed some errors on the TestAxesKwargs tests that were using logscales without passing any coordinates. I've also added an error raising if the passed coordinates have at least one non-positive element. Hope CIs pass now. Let me know if you feel that something else should be changed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913
846034540 https://github.com/pydata/xarray/pull/5334#issuecomment-846034540 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg0NjAzNDU0MA== santisoler 11541317 2021-05-21T15:28:25Z 2021-05-21T15:28:25Z CONTRIBUTOR

@shoyer Now I think this PR is ready to be reviewed. I added one test function for the _infer_interval_breaks private function with the optional scale="log" argument. I've also added a new test class for checking if calling pcolormesh with both xscale="log" and yscale="log" works as expected. I added the bug fix to whats-new.rst and run pre-commit run --all-files locally with success. I don't think we need to change anything in api.rst.

Let me know if you think I should change or add anything else, and feel free to make any suggestion on the review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913
845921245 https://github.com/pydata/xarray/pull/5334#issuecomment-845921245 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg0NTkyMTI0NQ== santisoler 11541317 2021-05-21T12:38:06Z 2021-05-21T12:38:06Z CONTRIBUTOR

Thanks @shoyer!

could you please look into adding a unit-test, to ensure that this stays fixed?

Yes! I got a little bit busier after I opened this PR and couldn't find the time to do so. Let me find a gap to add some tests. I'll ping you as soon as the PR is ready for a review. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913
845605670 https://github.com/pydata/xarray/pull/5334#issuecomment-845605670 https://api.github.com/repos/pydata/xarray/issues/5334 MDEyOklzc3VlQ29tbWVudDg0NTYwNTY3MA== shoyer 1217238 2021-05-21T02:26:18Z 2021-05-21T02:26:18Z MEMBER

this is great, thank you!

could you please look into adding a unit-test, to ensure that this stays fixed?

see http://xarray.pydata.org/en/stable/contributing.html#writing-tests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Properly infer intervals of pcolormesh when plotting on logscale 894753913

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);