home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 846034540

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5334#issuecomment-846034540 https://api.github.com/repos/pydata/xarray/issues/5334 846034540 MDEyOklzc3VlQ29tbWVudDg0NjAzNDU0MA== 11541317 2021-05-21T15:28:25Z 2021-05-21T15:28:25Z CONTRIBUTOR

@shoyer Now I think this PR is ready to be reviewed. I added one test function for the _infer_interval_breaks private function with the optional scale="log" argument. I've also added a new test class for checking if calling pcolormesh with both xscale="log" and yscale="log" works as expected. I added the bug fix to whats-new.rst and run pre-commit run --all-files locally with success. I don't think we need to change anything in api.rst.

Let me know if you think I should change or add anything else, and feel free to make any suggestion on the review.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  894753913
Powered by Datasette · Queries took 23.097ms · About: xarray-datasette