issue_comments

Table actions

7 rows where issue = 885038560 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Raise error for invalid reference date for encoding time units · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
840847901 https://github.com/pydata/xarray/pull/5288#issuecomment-840847901 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDg0NzkwMQ== max-sixty 5635139 2021-05-13T21:33:03Z 2021-05-13T21:33:03Z MEMBER

@gcaria no problem at all to submit another PR — the more the merrier

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840845930 https://github.com/pydata/xarray/pull/5288#issuecomment-840845930 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDg0NTkzMA== gcaria 44147817 2021-05-13T21:28:36Z 2021-05-13T21:28:36Z CONTRIBUTOR

Hi @dcherian, thanks for the merge, however I think there was one last edit left for this PR, i.e. put the tests in their own function. How should I go about this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840746531 https://github.com/pydata/xarray/pull/5288#issuecomment-840746531 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDc0NjUzMQ== dcherian 2448579 2021-05-13T18:27:03Z 2021-05-13T18:27:03Z MEMBER

Thanks @gcaria!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840006822 https://github.com/pydata/xarray/pull/5288#issuecomment-840006822 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDAwNjgyMg== pep8speaks 24736507 2021-05-12T18:31:02Z 2021-05-13T17:43:10Z NONE

Hello @gcaria! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-13 17:43:10 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840398106 https://github.com/pydata/xarray/pull/5288#issuecomment-840398106 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDM5ODEwNg== mathause 10194086 2021-05-13T08:12:11Z 2021-05-13T08:12:11Z MEMBER

Sorry I wasn't entirely clear - I meant "the tests belong in this general vicinity" - could you put them in their own function? You can also give yourself credit by adding something to whats-new (up to you).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840008512 https://github.com/pydata/xarray/pull/5288#issuecomment-840008512 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDAwODUxMg== gcaria 44147817 2021-05-12T18:33:50Z 2021-05-12T18:33:50Z CONTRIBUTOR

Done :) Since it was very little effort, I've also added a test for the other related error raising.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
838778708 https://github.com/pydata/xarray/pull/5288#issuecomment-838778708 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDgzODc3ODcwOA== mathause 10194086 2021-05-11T16:22:12Z 2021-05-11T16:22:12Z MEMBER

Looks good, thanks. As usual a test would be superb! You can add a new test in

https://github.com/pydata/xarray/blob/44f4ae11019ca9c9e7280c41d9d2fd86cf86ccce/xarray/tests/test_coding_times.py#L816

It can be as easy as

python with pytest.raises(ValueError, match="invalid reference date"): xr.coding.times.encode_cf_datetime([1, 2, 3], units='days since NO_YEAR')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);