issue_comments: 838778708

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5288#issuecomment-838778708 https://api.github.com/repos/pydata/xarray/issues/5288 838778708 MDEyOklzc3VlQ29tbWVudDgzODc3ODcwOA== 10194086 2021-05-11T16:22:12Z 2021-05-11T16:22:12Z MEMBER

Looks good, thanks. As usual a test would be superb! You can add a new test in

https://github.com/pydata/xarray/blob/44f4ae11019ca9c9e7280c41d9d2fd86cf86ccce/xarray/tests/test_coding_times.py#L816

It can be as easy as

python with pytest.raises(ValueError, match="invalid reference date"): xr.coding.times.encode_cf_datetime([1, 2, 3], units='days since NO_YEAR')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   885038560