issue_comments

Table actions

3 rows where issue = 874038993 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • xfail very flaky test · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
831012940 https://github.com/pydata/xarray/pull/5245#issuecomment-831012940 https://api.github.com/repos/pydata/xarray/issues/5245 MDEyOklzc3VlQ29tbWVudDgzMTAxMjk0MA== max-sixty 5635139 2021-05-03T04:28:35Z 2021-05-03T04:28:35Z MEMBER

It does seem this is happening a fair amount, so I'll merge this — feel free to revert if I'm mistaken. I think it may be worth also xfailing the Pydap tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xfail very flaky test 874038993
830973417 https://github.com/pydata/xarray/pull/5245#issuecomment-830973417 https://api.github.com/repos/pydata/xarray/issues/5245 MDEyOklzc3VlQ29tbWVudDgzMDk3MzQxNw== shoyer 1217238 2021-05-03T00:47:53Z 2021-05-03T00:47:53Z MEMBER

In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.

Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

👍

It does look like the "TestPydapOnline" tests are still a culprit here...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xfail very flaky test 874038993
830926630 https://github.com/pydata/xarray/pull/5245#issuecomment-830926630 https://api.github.com/repos/pydata/xarray/issues/5245 MDEyOklzc3VlQ29tbWVudDgzMDkyNjYzMA== max-sixty 5635139 2021-05-02T23:36:38Z 2021-05-02T23:36:38Z MEMBER

I think this is wrong and it's actually these?

=========================== short test summary info ============================ FAILED xarray/tests/test_backends.py::TestPydapOnline::test_cmp_local_file - ... FAILED xarray/tests/test_backends.py::TestPydapOnline::test_dask - webob.exc.... FAILED xarray/tests/test_backends.py::TestPydapOnline::test_compatible_to_netcdf

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xfail very flaky test 874038993

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);