issue_comments: 830973417

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5245#issuecomment-830973417 https://api.github.com/repos/pydata/xarray/issues/5245 830973417 MDEyOklzc3VlQ29tbWVudDgzMDk3MzQxNw== 1217238 2021-05-03T00:47:53Z 2021-05-03T00:47:53Z MEMBER

In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.

Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

👍

It does look like the "TestPydapOnline" tests are still a culprit here...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   874038993