issue_comments

Table actions

6 rows where issue = 863506023 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 6 ✖

issue 1

  • Fix lag in Jupyter caused by CSS in `_repr_html_` · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
870045898 https://github.com/pydata/xarray/pull/5201#issuecomment-870045898 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MDA0NTg5OA== max-sixty 5635139 2021-06-28T21:12:30Z 2021-06-28T21:12:30Z MEMBER

Marked this as "plan to merge" — please comment if you think that's a bad tradeoff between performance and dark mode.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
860087366 https://github.com/pydata/xarray/pull/5201#issuecomment-860087366 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg2MDA4NzM2Ng== max-sixty 5635139 2021-06-12T17:55:20Z 2021-06-12T17:55:20Z MEMBER

It would be a shame to lose the benefits of this.

  • It seems like between us we're not going to figure out the dark mode issue. Are there any CSS people out there who could offer guidance?
  • Assuming not, should we merge this knowing dark mode* will look worse? I wrote above we should fix it, but I had thought that was a few extra lines, rather than intractable. I would probably vote to prioritize performance above aesthetics.

(* Did you know that research suggests we're either the same or slightly better at reading light mode?? Is dark mode LARPing?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828230282 https://github.com/pydata/xarray/pull/5201#issuecomment-828230282 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODIzMDI4Mg== max-sixty 5635139 2021-04-28T07:46:26Z 2021-04-28T07:46:26Z MEMBER

I am out of comfort zone with CSS & JS — but does Toggle Developer Tools in VSCode give you access to the DOM?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828164312 https://github.com/pydata/xarray/pull/5201#issuecomment-828164312 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODE2NDMxMg== max-sixty 5635139 2021-04-28T05:51:39Z 2021-04-28T05:51:39Z MEMBER

Thanks a lot @andersy005

That looks concerning enough we should fix before merging:

@SimonHeybrock how would you feel about giving the vscode-dark a swing too?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
826145021 https://github.com/pydata/xarray/pull/5201#issuecomment-826145021 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyNjE0NTAyMQ== max-sixty 5635139 2021-04-24T19:53:35Z 2021-04-24T19:53:35Z MEMBER

@SimonHeybrock would you be able to see whether running this with vscode-dark is acceptable? We can merge with a TODO or issue assuming it doesn't make the issue worse in that environment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
823845269 https://github.com/pydata/xarray/pull/5201#issuecomment-823845269 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyMzg0NTI2OQ== max-sixty 5635139 2021-04-21T07:32:24Z 2021-04-21T07:32:24Z MEMBER

Thanks @SimonHeybrock ! Tagging @jsignell & @benbovy as the experts!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);