home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 860087366

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5201#issuecomment-860087366 https://api.github.com/repos/pydata/xarray/issues/5201 860087366 MDEyOklzc3VlQ29tbWVudDg2MDA4NzM2Ng== 5635139 2021-06-12T17:55:20Z 2021-06-12T17:55:20Z MEMBER

It would be a shame to lose the benefits of this.

  • It seems like between us we're not going to figure out the dark mode issue. Are there any CSS people out there who could offer guidance?
  • Assuming not, should we merge this knowing dark mode* will look worse? I wrote above we should fix it, but I had thought that was a few extra lines, rather than intractable. I would probably vote to prioritize performance above aesthetics.

(* Did you know that research suggests we're either the same or slightly better at reading light mode?? Is dark mode LARPing?)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  863506023
Powered by Datasette · Queries took 0.602ms · About: xarray-datasette