issue_comments

Table actions

2 rows where issue = 860909006 and user = 226037 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • alexamici · 2 ✖

issue 1

  • Replace raises_regex with pytest.raises · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
822685095 https://github.com/pydata/xarray/pull/5188#issuecomment-822685095 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY4NTA5NQ== alexamici 226037 2021-04-19T18:33:23Z 2021-04-19T18:34:12Z MEMBER

I would do another regex special to check whether it contains a \

@max-sixty I was thinking to something more brutal: I would drop the r-prefix everywhere and fix by hand the failing tests (if any) ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822677989 https://github.com/pydata/xarray/pull/5188#issuecomment-822677989 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY3Nzk4OQ== alexamici 226037 2021-04-19T18:21:59Z 2021-04-19T18:21:59Z MEMBER

@max-sixty I like the cleanup even it it is rather big. I for one find it very confusing when tests use non standard helpers.

BTW, I think you can skip the r-prefix everywhere making the change even more appealing. It is only useful when using \ operands in the the match string which is almost never the case in xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);