issue_comments

Table actions

9 rows where issue = 860909006 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Replace raises_regex with pytest.raises · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
822826570 https://github.com/pydata/xarray/pull/5188#issuecomment-822826570 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjgyNjU3MA== keewis 14808389 2021-04-19T22:25:02Z 2021-04-19T22:25:02Z MEMBER

of course, that does not explain why raises_regex passes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822826163 https://github.com/pydata/xarray/pull/5188#issuecomment-822826163 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjgyNjE2Mw== keewis 14808389 2021-04-19T22:24:17Z 2021-04-19T22:24:17Z MEMBER

I'm not sure why, but open_dataset(f, engine="scipy") seems to close the file if a TypeError is raised: if I put python print(f, f.closed) try: open_dataset(f, engine="scipy") except TypeError: pass print(f, f.closed) before f.seek(0), the second print reports f.closed = True and f.seek fails. Is that a bug in the scipy engine?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822812140 https://github.com/pydata/xarray/pull/5188#issuecomment-822812140 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjgxMjE0MA== max-sixty 5635139 2021-04-19T21:55:05Z 2021-04-19T21:55:05Z MEMBER

that still fails, but the error is ValueError: seek of closed file for f.seek(8)

Yes! This is the error I was getting

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822698126 https://github.com/pydata/xarray/pull/5188#issuecomment-822698126 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY5ODEyNg== keewis 14808389 2021-04-19T18:52:30Z 2021-04-19T18:53:55Z MEMBER

Apart from that, does anyone know a good reason to keep our own impl?

I think our own implementation precedes the match parameter, so there's no reason for keeping it. I'll try to find the reason why the backends tests fail.

This is weird: 3f1d3d1

that's because match is a keyword-only parameter, *args seems to be used only when called with a function: python pytest.raises(Exc, func, match="passed on").match("my pattern")

Edit: that still fails, but the error is ValueError: seek of closed file for f.seek(8)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822686424 https://github.com/pydata/xarray/pull/5188#issuecomment-822686424 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY4NjQyNA== max-sixty 5635139 2021-04-19T18:35:29Z 2021-04-19T18:35:29Z MEMBER

I'll merge this version which has most of them.

Ideally we would do all of them — otherwise people will keep using the raises_regex — we had that issue with the self.assert functions a few years ago. But we can finish it up another time.

fix by hand the failing tests (if any) ;)

😬 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822685095 https://github.com/pydata/xarray/pull/5188#issuecomment-822685095 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY4NTA5NQ== alexamici 226037 2021-04-19T18:33:23Z 2021-04-19T18:34:12Z MEMBER

I would do another regex special to check whether it contains a \

@max-sixty I was thinking to something more brutal: I would drop the r-prefix everywhere and fix by hand the failing tests (if any) ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822680772 https://github.com/pydata/xarray/pull/5188#issuecomment-822680772 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY4MDc3Mg== max-sixty 5635139 2021-04-19T18:26:25Z 2021-04-19T18:26:25Z MEMBER

BTW, I think you can skip the r-prefix everywhere making the change even more appealing. It is only useful when using \ operands in the the match string which is almost never the case in xarray.

Yes but not 100%! I would do another regex special to check whether it contains a \, but the weekend fun is over and this may have to wait until next time :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822677989 https://github.com/pydata/xarray/pull/5188#issuecomment-822677989 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjY3Nzk4OQ== alexamici 226037 2021-04-19T18:21:59Z 2021-04-19T18:21:59Z MEMBER

@max-sixty I like the cleanup even it it is rather big. I for one find it very confusing when tests use non standard helpers.

BTW, I think you can skip the r-prefix everywhere making the change even more appealing. It is only useful when using \ operands in the the match string which is almost never the case in xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006
822596534 https://github.com/pydata/xarray/pull/5188#issuecomment-822596534 https://api.github.com/repos/pydata/xarray/issues/5188 MDEyOklzc3VlQ29tbWVudDgyMjU5NjUzNA== max-sixty 5635139 2021-04-19T16:16:02Z 2021-04-19T16:16:02Z MEMBER

This is weird: https://github.com/pydata/xarray/pull/5188/commits/3f1d3d13326e3d871cd15bb4aad133f17de1933a

Apart from that, does anyone know a good reason to keep our own impl?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace raises_regex with pytest.raises 860909006

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);