issue_comments

Table actions

3 rows where issue = 860577067 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Enable clip broadcasting, with apply_ufunc · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
822676111 https://github.com/pydata/xarray/pull/5184#issuecomment-822676111 https://api.github.com/repos/pydata/xarray/issues/5184 MDEyOklzc3VlQ29tbWVudDgyMjY3NjExMQ== max-sixty 5635139 2021-04-19T18:18:57Z 2021-04-19T18:18:57Z MEMBER

Looks good to me though dask tests are missing. We can add them in a future PR if you don't want to do it now.

They're there! The magic of fixtures is da is attempted with both a dask and numpy backend: https://github.com/pydata/xarray/pull/5184/files#diff-ca5c2de2fe6e9e25fbf22bd53e4976c15da74900dfb14deb7e6e87f5377230e3R6438

Does that make sense, assuming I'm not missing anything? Too magical?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable clip broadcasting, with apply_ufunc 860577067
822648082 https://github.com/pydata/xarray/pull/5184#issuecomment-822648082 https://api.github.com/repos/pydata/xarray/issues/5184 MDEyOklzc3VlQ29tbWVudDgyMjY0ODA4Mg== pep8speaks 24736507 2021-04-19T17:34:41Z 2021-04-19T18:17:58Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-04-19 18:17:58 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable clip broadcasting, with apply_ufunc 860577067
822611859 https://github.com/pydata/xarray/pull/5184#issuecomment-822611859 https://api.github.com/repos/pydata/xarray/issues/5184 MDEyOklzc3VlQ29tbWVudDgyMjYxMTg1OQ== max-sixty 5635139 2021-04-19T16:37:56Z 2021-04-19T16:37:56Z MEMBER

The tests are in a reasonable state — not perfect — but maybe good enough to proceed. Are there any cases that are missing currently?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable clip broadcasting, with apply_ufunc 860577067

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);