home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 822676111

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5184#issuecomment-822676111 https://api.github.com/repos/pydata/xarray/issues/5184 822676111 MDEyOklzc3VlQ29tbWVudDgyMjY3NjExMQ== 5635139 2021-04-19T18:18:57Z 2021-04-19T18:18:57Z MEMBER

Looks good to me though dask tests are missing. We can add them in a future PR if you don't want to do it now.

They're there! The magic of fixtures is da is attempted with both a dask and numpy backend: https://github.com/pydata/xarray/pull/5184/files#diff-ca5c2de2fe6e9e25fbf22bd53e4976c15da74900dfb14deb7e6e87f5377230e3R6438

Does that make sense, assuming I'm not missing anything? Too magical?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  860577067
Powered by Datasette · Queries took 0.453ms · About: xarray-datasette