issue_comments

Table actions

7 rows where issue = 855330062 and user = 226037 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • alexamici · 7 ✖

issue 1

  • failing CI · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
826344428 https://github.com/pydata/xarray/issues/5138#issuecomment-826344428 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgyNjM0NDQyOA== alexamici 226037 2021-04-25T15:41:07Z 2021-04-25T15:41:07Z MEMBER

I don't know, I've never managed to get cfgrib and xarray to install on python 3.9. The conda solver fails.

It looks like there is a conflict between xarray and eccodes dependencies, but I didn't investigate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817864442 https://github.com/pydata/xarray/issues/5138#issuecomment-817864442 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzg2NDQ0Mg== alexamici 226037 2021-04-12T14:34:13Z 2021-04-12T14:34:13Z MEMBER

Yes, I would close the issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817566465 https://github.com/pydata/xarray/issues/5138#issuecomment-817566465 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzU2NjQ2NQ== alexamici 226037 2021-04-12T07:37:25Z 2021-04-12T07:37:25Z MEMBER

@keewis after merging #5139 the CI should not be failing anymore. The problem is now that cfgrib may not be consistently tested on all jobs and failures are silent.

I'll wait a bit for the fix in python-eccodes, otherwise I'll do a new release of the conda package of cfgrib.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817557923 https://github.com/pydata/xarray/issues/5138#issuecomment-817557923 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzU1NzkyMw== alexamici 226037 2021-04-12T07:25:03Z 2021-04-12T07:25:03Z MEMBER

Technically this is an incompatibility between python-eccodes and eccodes, I'm trying to resolve it via a PR to the python-eccodes-feedstock: https://github.com/conda-forge/python-eccodes-feedstock/pull/71

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817358999 https://github.com/pydata/xarray/issues/5138#issuecomment-817358999 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1ODk5OQ== alexamici 226037 2021-04-11T19:23:14Z 2021-04-11T19:28:45Z MEMBER

As a general measure I would add ImportError to the exception caught on import so we avoid to crash xarray:

https://github.com/pydata/xarray/blob/186c2ff6542f090a8e97ffb755f866030be30be9/xarray/backends/cfgrib_.py#L18-L29

To work around the current problem we may need to add a eccodes>=2.21.0 to the CI :/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817357498 https://github.com/pydata/xarray/issues/5138#issuecomment-817357498 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1NzQ5OA== alexamici 226037 2021-04-11T19:12:13Z 2021-04-11T19:12:30Z MEMBER

Thanks @keewis! ATM the main suspect is a flaky the dependency between python-eccodes and eccodes, not cfgrib itself. So it may look like a random error in CI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062
817355970 https://github.com/pydata/xarray/issues/5138#issuecomment-817355970 https://api.github.com/repos/pydata/xarray/issues/5138 MDEyOklzc3VlQ29tbWVudDgxNzM1NTk3MA== alexamici 226037 2021-04-11T19:00:30Z 2021-04-11T19:00:30Z MEMBER

Looking into ecmwf/cfgrib#226 that seems related.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   failing CI 855330062

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);